Skip to content

Commit da59990

Browse files
authored
Run tests against pre-release versions (#16872)
* Run tests against pre-release versions * Updates
1 parent e6bdbf8 commit da59990

File tree

2 files changed

+29
-14
lines changed

2 files changed

+29
-14
lines changed

.github/workflows/build-test.yml

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -307,13 +307,13 @@ jobs:
307307
tags: '^[^@]+$|@mandatory'
308308
os: ubuntu-latest
309309
ipywidgetsVersion: ''
310-
# - jupyterConnection: remote
311-
# python: python
312-
# pythonVersion: '3.10'
313-
# packageVersion: 'prerelease'
314-
# tags: '^[^@]+$|@mandatory'
315-
# os: ubuntu-latest
316-
# ipywidgetsVersion: ''
310+
- jupyterConnection: remote
311+
python: python
312+
pythonVersion: '3.10'
313+
packageVersion: 'prerelease'
314+
tags: '^[^@]+$|@mandatory'
315+
os: ubuntu-latest
316+
ipywidgetsVersion: ''
317317
- jupyterConnection: web
318318
python: python
319319
pythonVersion: '3.10'
@@ -353,13 +353,13 @@ jobs:
353353
os: ubuntu-latest
354354
ipywidgetsVersion: ''
355355
# Pre-Release Versions
356-
# - jupyterConnection: raw
357-
# python: python
358-
# pythonVersion: '3.10'
359-
# packageVersion: 'prerelease'
360-
# tags: '^[^@]+$|@mandatory|@kernelCore|@python|@jupyter'
361-
# os: ubuntu-latest
362-
# ipywidgetsVersion: ''
356+
- jupyterConnection: raw
357+
python: python
358+
pythonVersion: '3.10'
359+
packageVersion: 'prerelease'
360+
tags: '^[^@]+$|@mandatory|@kernelCore|@python|@jupyter|@widgets'
361+
os: ubuntu-latest
362+
ipywidgetsVersion: ''
363363
# Without Python
364364
- jupyterConnection: raw
365365
python: noPython
@@ -383,6 +383,9 @@ jobs:
383383
- name: Generate Tag Variable
384384
run: echo "TAGSVAR=${{ matrix.tags }}}" >> $GITHUB_ENV
385385

386+
- name: Generate Package PreRelease Variable
387+
run: echo "PACKAGE_PRE_RELEASE=${{ matrix.packageVersion }}" >> $GITHUB_ENV
388+
386389
- name: Generate Friendly Variable
387390
run:
388391
# Generate a file friendly tag name for the test run (used for the artifacts)

src/test/datascience/notebook/kernelCrashes.vscode.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@ suite('VSCode Notebook Kernel Error Handling - @kernelCore', function () {
222222
);
223223
}
224224
test('Ensure we get an error displayed in cell output and prompt when user has a file named random.py next to the ipynb file', async function () {
225+
// eslint-disable-next-line local-rules/dont-use-process
226+
if (process.env.PACKAGE_PRE_RELEASE === 'prerelease') {
227+
return this.skip();
228+
}
225229
await runAndFailWithKernelCrash();
226230
const cell3 = await notebook.appendCodeCell('print("123412341234")');
227231
const kernel = kernelProvider.get(notebook)!;
@@ -247,6 +251,10 @@ suite('VSCode Notebook Kernel Error Handling - @kernelCore', function () {
247251
assert.strictEqual(cell3.executionSummary?.executionOrder, 1);
248252
});
249253
test('Ensure cell output does not have errors when execution fails due to dead kernel', async function () {
254+
// eslint-disable-next-line local-rules/dont-use-process
255+
if (process.env.PACKAGE_PRE_RELEASE === 'prerelease') {
256+
return this.skip();
257+
}
250258
await runAndFailWithKernelCrash();
251259
const cell3 = await notebook.appendCodeCell('print("123412341234")');
252260
const kernel = kernelProvider.get(notebook)!;
@@ -267,6 +275,10 @@ suite('VSCode Notebook Kernel Error Handling - @kernelCore', function () {
267275
assert.isUndefined(cell3.executionSummary?.executionOrder, 'Should not have an execution order');
268276
});
269277
test('Ensure we get only one prompt to restart kernel when running all cells against a dead kernel', async function () {
278+
// eslint-disable-next-line local-rules/dont-use-process
279+
if (process.env.PACKAGE_PRE_RELEASE === 'prerelease') {
280+
return this.skip();
281+
}
270282
await runAndFailWithKernelCrash();
271283
await notebook.appendCodeCell('print("123412341234")');
272284
const kernel = kernelProvider.get(notebook)!;

0 commit comments

Comments
 (0)