Skip to content

Commit e2b6c36

Browse files
committed
More merge cleanup
1 parent d9afa1a commit e2b6c36

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

src/notebooks/controllers/vscodeNotebookController.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ import { initializeInteractiveOrNotebookTelemetryBasedOnUserAction } from '../..
7171
import { NotebookCellLanguageService } from '../languages/cellLanguageService';
7272
import { IDataScienceErrorHandler } from '../../kernels/errors/types';
7373
import { ITrustedKernelPaths } from '../../kernels/raw/finder/types';
74-
import { DeepnoteController } from '../../kernels/deepnote/deepnoteController';
74+
import { KernelController } from '../../kernels/kernelController';
7575
import { RemoteKernelReconnectBusyIndicator } from './remoteKernelReconnectBusyIndicator';
7676
import { LastCellExecutionTracker } from '../../kernels/execution/lastCellExecutionTracker';
7777
import type { IAnyMessageArgs } from '@jupyterlab/services/lib/kernel/kernel';
@@ -548,7 +548,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
548548
// Creating these execution objects marks the cell as queued for execution (vscode will update cell UI).
549549
type CellExec = { cell: NotebookCell; exec: NotebookCellExecution };
550550
const cellExecs: CellExec[] = (this.cellQueue.get(doc) || []).map((cell) => {
551-
const exec = this.createCellExecutionIfNecessary(cell, new DeepnoteController(this.controller));
551+
const exec = this.createCellExecutionIfNecessary(cell, new KernelController(this.controller));
552552
return { cell, exec };
553553
});
554554
this.cellQueue.delete(doc);
@@ -561,7 +561,7 @@ export class VSCodeNotebookController implements Disposable, IVSCodeNotebookCont
561561

562562
// Connect to a matching kernel if possible (but user may pick a different one)
563563
let currentContext: 'start' | 'execution' = 'start';
564-
let controller: IKernelController = new DeepnoteController(this.controller);
564+
let controller: IKernelController = new KernelController(this.controller);
565565
const lastCellExecutionTracker = this.serviceContainer.get<LastCellExecutionTracker>(LastCellExecutionTracker);
566566
let kernel: IKernel | undefined;
567567
try {

src/notebooks/deepnote/deepnoteSchemas.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import { z } from 'zod';
22

3-
import { OUTPUT_BLOCK_METADATA_KEY } from './deepnoteConstants';
4-
53
export const DeepnoteChartBigNumberOutputSchema = z.object({
64
title: z.string().nullish(),
75
value: z.string().nullish(),
@@ -45,11 +43,5 @@ export const DeepnoteBigNumberMetadataSchema = z.object({
4543
.transform((val) => val ?? null)
4644
});
4745

48-
export function getDeepnoteBlockMetadataSchema<T extends z.ZodTypeAny>(schema: T) {
49-
return z.object({
50-
[OUTPUT_BLOCK_METADATA_KEY]: schema
51-
});
52-
}
53-
5446
export type DeepnoteChartBigNumberOutput = z.infer<typeof DeepnoteChartBigNumberOutputSchema>;
5547
export type DeepnoteBigNumberMetadata = z.infer<typeof DeepnoteBigNumberMetadataSchema>;

0 commit comments

Comments
 (0)