Skip to content

Commit e40fffb

Browse files
Update npm ci to npm install everywhere except CI workflow files
Changes: - Updated CD workflow (package.yml) to use npm install - Updated deps workflow (deps.yml) to use npm install - Updated copilot-setup-steps workflow to use npm install - Updated GitHub actions (npm-ci, build-vsix) to use npm install - Updated Azure pipeline files (stable, pre-release) to use npm install - Updated devcontainer files to use npm install in comments - CI workflow files (ci.yml) continue to use npm ci as expected This ensures npm ci is only used in CI environments where reproducible builds are critical, while npm install is used everywhere else for flexibility.
1 parent f56b0ec commit e40fffb

File tree

9 files changed

+16
-16
lines changed

9 files changed

+16
-16
lines changed

.devcontainer/dev-with-python/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"],
3535
// Use 'postCreateCommand' to run commands after the container is created.
36-
// "postCreateCommand": "npm ci",
36+
// "postCreateCommand": "npm install",
3737
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
3838
"remoteUser": "vscode"
3939
}

.devcontainer/dev/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
},
2020
"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"]
2121
// Use 'postCreateCommand' to run commands after the container is created.
22-
// "postCreateCommand": "npm ci",
22+
// "postCreateCommand": "npm install",
2323
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
2424
// , "remoteUser": "vscode"
2525
}

.github/actions/build-vsix/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ outputs:
99
runs:
1010
using: 'composite'
1111
steps:
12-
# This is faster than running `npm ci`, we do not want to build zmq, as its already built by us.
13-
- run: npm ci --ignore-scripts --prefer-offline --no-audit
12+
# This is faster than running `npm install`, we do not want to build zmq, as its already built by us.
13+
- run: npm install --ignore-scripts --prefer-offline --no-audit
1414
shell: bash
1515

1616
# Run again, as the download of zmq binaries could have failed with 403 errors

.github/actions/npm-ci/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
name: 'Install dependencies (npm ci)'
1+
name: 'Install dependencies (npm install)'
22
description: 'npm install (with GITHUB_TOKEN to run postinstall step)'
33

44
runs:
55
using: 'composite'
66
steps:
7-
- run: npm ci --foreground-scripts --prefer-offline
7+
- run: npm install --foreground-scripts --prefer-offline
88
env:
99
npm_config_build_from_source: true
1010
shell: bash

.github/workflows/copilot-setup-steps.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ jobs:
5757
path: ./out
5858
key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}
5959

60-
# This is faster than running `npm ci`, we do not want to build zmq, etc.
60+
# This is faster than running `npm install`, we do not want to build zmq, etc.
6161
# Let that happen in other jobs, this job needs to be fast
62-
- name: npm ci
63-
run: npm ci --ignore-scripts --prefer-offline --no-audit
62+
- name: npm install
63+
run: npm install --ignore-scripts --prefer-offline --no-audit
6464
env:
6565
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6666

.github/workflows/deps.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
scope: '@deepnote'
3333

3434
- name: Install dependencies
35-
run: npm ci --prefer-offline --no-audit
35+
run: npm install --prefer-offline --no-audit
3636
env:
3737
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3838

@@ -63,7 +63,7 @@ jobs:
6363
cache: 'npm'
6464

6565
- name: Install dependencies
66-
run: npm ci --prefer-offline --no-audit
66+
run: npm install --prefer-offline --no-audit
6767

6868
- name: Run postinstall
6969
run: npm run postinstall

.github/workflows/package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
scope: '@deepnote'
3434

3535
- name: Install dependencies
36-
run: npm ci --prefer-offline --no-audit
36+
run: npm install --prefer-offline --no-audit
3737
env:
3838
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3939

build/azure-pipeline.pre-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ extends:
7373
addToPath: true
7474
architecture: 'x64'
7575

76-
- script: npm ci --foreground-scripts
77-
displayName: npm ci
76+
- script: npm install --foreground-scripts
77+
displayName: npm install
7878
env:
7979
npm_config_build_from_source: true
8080
VSC_VSCE_TARGET: $(vsceTarget)

build/azure-pipeline.stable.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ extends:
6767
addToPath: true
6868
architecture: 'x64'
6969

70-
- script: npm ci --foreground-scripts
71-
displayName: npm ci
70+
- script: npm install --foreground-scripts
71+
displayName: npm install
7272
env:
7373
npm_config_build_from_source: true
7474
VSC_VSCE_TARGET: $(vsceTarget)

0 commit comments

Comments
 (0)