Skip to content

Commit eba3bd1

Browse files
Artmannclaude
andcommitted
fix: correct upstream repository references to microsoft/vscode-jupyter-hub
Fixes incorrect references that were changed during the blanket find-and-replace operation: - Changed deepnote/vscode-deepnote-hub back to microsoft/vscode-jupyter-hub in jupyterUtils.ts and jupyterSelfCertsError.ts - These references point to upstream Microsoft repositories, not Deepnote repos - Preserves important context for debugging and understanding the codebase Addresses CodeRabbit review feedback. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 4738a94 commit eba3bd1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/kernels/jupyter/jupyterUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export function createJupyterConnectionInfo(
9999

100100
// When using built in Jupyter Server providers, & we have a token
101101
// Then we need to ensure the same token information is setup as a header for websockets as well.
102-
// This same change had to be made for JuptyerHub extension, see https://github.com/deepnote/vscode-deepnote-hub/pull/65
102+
// This same change had to be made for JuptyerHub extension, see https://github.com/microsoft/vscode-jupyter-hub/pull/65
103103
if (
104104
token &&
105105
jupyterHandle.extensionId === JVSC_EXTENSION_ID &&

src/platform/errors/jupyterSelfCertsError.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ export class JupyterSelfCertsError extends BaseError {
2020
const message = (err as undefined | { message: string })?.message ?? '';
2121
return (
2222
message.indexOf('reason: self signed certificate') >= 0 ||
23-
// https://github.com/deepnote/vscode-deepnote-hub/issues/36#issuecomment-1854097594
23+
// https://github.com/microsoft/vscode-jupyter-hub/issues/36#issuecomment-1854097594
2424
message.indexOf('reason: unable to verify the first certificate') >= 0 ||
25-
// https://github.com/deepnote/vscode-deepnote-hub/issues/36#issuecomment-1761234981
25+
// https://github.com/microsoft/vscode-jupyter-hub/issues/36#issuecomment-1761234981
2626
message.indexOf('reason: unable to get issuer certificate') >= 0 ||
2727
// https://github.com/microsoft/vscode-jupyter/issues/7558#issuecomment-993054968
2828
message.indexOf("is not in the cert's list") >= 0

0 commit comments

Comments
 (0)