Skip to content

Commit 6b168c4

Browse files
committed
merge clear_ram and dump_modules into keep_in_ram
1 parent a05b530 commit 6b168c4

File tree

9 files changed

+15
-17
lines changed

9 files changed

+15
-17
lines changed

autointent/configs/_optimization.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@ class LoggingConfig(BaseModel):
2828
"""Path to the directory with different runs."""
2929
run_name: str = Field(default_factory=get_run_name)
3030
"""Name of the run. If None, a random name will be generated"""
31-
dump_modules: bool = False
32-
"""Whether to dump the modules or not"""
33-
clear_ram: bool = False
34-
"""Whether to clear the RAM after dumping the modules"""
31+
keep_in_ram: bool = True
32+
"""Whether to store modules in RAM or dump them into file system."""
3533
report_to: list[str] | None = None
3634
"""List of callbacks to report to. If None, no callbacks will be used"""
3735

autointent/context/_context.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ def get_dump_dir(self) -> Path | None:
208208
209209
:return: Path to the dump directory or None if dumping is disabled.
210210
"""
211-
if self.logging_config.dump_modules:
211+
if not self.logging_config.keep_in_ram:
212212
return self.logging_config.dump_dir
213213
return None
214214

@@ -234,7 +234,7 @@ def is_ram_to_clear(self) -> bool:
234234
235235
:return: True if RAM clearing is enabled, False otherwise.
236236
"""
237-
return self.logging_config.clear_ram
237+
return not self.logging_config.keep_in_ram
238238

239239
def has_saved_modules(self) -> bool:
240240
"""

tests/callback/test_callback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def test_pipeline_callbacks(dataset):
8383
pipeline_optimizer = Pipeline.from_search_space(search_space)
8484
context = Context()
8585
context.configure_vector_index(VectorIndexConfig(save_db=True))
86-
context.configure_logging(LoggingConfig(run_name="dummy_run_name", project_dir=project_dir, dump_modules=False))
86+
context.configure_logging(LoggingConfig(run_name="dummy_run_name", project_dir=project_dir, keep_in_ram=True))
8787
context.callback_handler = CallbackHandler([DummyCallback])
8888
context.set_dataset(dataset)
8989

tests/nodes/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def get_context(multilabel):
8282
if multilabel:
8383
dataset = dataset.to_multilabel()
8484
res.set_dataset(dataset)
85-
res.configure_logging(LoggingConfig(project_dir=project_dir, dump_modules=True))
85+
res.configure_logging(LoggingConfig(project_dir=project_dir, keep_in_ram=False))
8686
res.configure_vector_index(VectorIndexConfig(), EmbedderConfig(device="cpu"))
8787
res.configure_cross_encoder(CrossEncoderConfig())
8888
return res

tests/pipeline/test_inference.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def test_inference_config(dataset, task_type):
1515

1616
pipeline_optimizer = Pipeline.from_search_space(search_space)
1717

18-
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, dump_modules=True, clear_ram=True))
18+
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, keep_in_ram=False))
1919
pipeline_optimizer.set_config(VectorIndexConfig(save_db=True))
2020
pipeline_optimizer.set_config(EmbedderConfig(batch_size=16, max_length=32, device="cpu"))
2121
pipeline_optimizer.set_config(CrossEncoderConfig())
@@ -47,7 +47,7 @@ def test_inference_context(dataset, task_type):
4747

4848
pipeline = Pipeline.from_search_space(search_space)
4949

50-
pipeline.set_config(LoggingConfig(project_dir=project_dir, dump_modules=False, clear_ram=False))
50+
pipeline.set_config(LoggingConfig(project_dir=project_dir, keep_in_ram=True))
5151
pipeline.set_config(VectorIndexConfig(save_db=True))
5252
pipeline.set_config(EmbedderConfig(batch_size=16, max_length=32, device="cpu"))
5353

tests/pipeline/test_optimization.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_no_context_optimization(dataset, task_type):
2424

2525
pipeline_optimizer = Pipeline.from_search_space(search_space)
2626

27-
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, dump_modules=False))
27+
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, keep_in_ram=True))
2828
pipeline_optimizer.set_config(VectorIndexConfig())
2929
pipeline_optimizer.set_config(EmbedderConfig(batch_size=16, max_length=32, device="cpu"))
3030

@@ -45,7 +45,7 @@ def test_save_db(dataset, task_type):
4545

4646
pipeline_optimizer = Pipeline.from_search_space(search_space)
4747

48-
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, dump_modules=False))
48+
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, keep_in_ram=True))
4949
pipeline_optimizer.set_config(VectorIndexConfig(save_db=True))
5050
pipeline_optimizer.set_config(EmbedderConfig(batch_size=16, max_length=32, device="cpu"))
5151

@@ -66,7 +66,7 @@ def test_dump_modules(dataset, task_type):
6666

6767
pipeline_optimizer = Pipeline.from_search_space(search_space)
6868

69-
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, dump_modules=True))
69+
pipeline_optimizer.set_config(LoggingConfig(project_dir=project_dir, keep_in_ram=False))
7070
pipeline_optimizer.set_config(VectorIndexConfig())
7171
pipeline_optimizer.set_config(EmbedderConfig(batch_size=16, max_length=32, device="cpu"))
7272

user_guides/advanced/04_reporting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
from pathlib import Path
7575

7676
log_config = LoggingConfig(
77-
run_name="test_tensorboard", report_to=["tensorboard"], dirpath=Path("test_tensorboard"), dump_modules=False
77+
run_name="test_tensorboard", report_to=["tensorboard"], dirpath=Path("test_tensorboard"), keep_in_ram=True
7878
)
7979

8080
pipeline_optimizer.set_config(log_config)

user_guides/basic_usage/03_automl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
from pathlib import Path
125125
from autointent.configs import LoggingConfig
126126

127-
logging_config = LoggingConfig(project_dir=Path.cwd() / "runs", dump_modules=False, clear_ram=False)
127+
logging_config = LoggingConfig(project_dir=Path.cwd() / "runs", keep_in_ram=True)
128128
custom_pipeline.set_config(logging_config)
129129

130130
# %% [markdown]

user_guides/basic_usage/04_inference.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
# %%
6868
from autointent.configs import LoggingConfig
6969

70-
logging_config = LoggingConfig(dump_modules=True, clear_ram=True)
70+
logging_config = LoggingConfig(keep_in_ram=False)
7171

7272
# %% [markdown]
7373
"""
@@ -82,7 +82,7 @@
8282

8383
dataset = Dataset.from_hub("AutoIntent/clinc150_subset")
8484
pipeline = Pipeline.from_search_space(search_space)
85-
pipeline.set_config(LoggingConfig(dump_modules=True, clear_ram=True))
85+
pipeline.set_config(LoggingConfig(keep_in_ram=False))
8686
pipeline.set_config(VectorIndexConfig(save_db=True))
8787

8888
# %% [markdown]

0 commit comments

Comments
 (0)