chore: remove config test (#795)

Author: dazy-ds

packages/ragbits-chat/CHANGELOG.md

@@ -1,6 +1,7 @@
 # CHANGELOG
 
 ## Unreleased
+- Remove redundant test for `/api/config` endpoint (#795)
 - Fix bug causing infinite initialization screen (#793)
 - Fix bug that caused messages to be sent when changing chat settings; simplify and harden history logic (#791)
 - Add `clear_message` event type allowing to reset whole message (#789)

typescript/ui/__tests__/integration/intergation.test.tsx

@@ -12,7 +12,6 @@ import {
 import {
   act,
   render,
-  renderHook,
   waitFor,
   screen,
   fireEvent,
@@ -26,7 +25,6 @@ import {
   MessageRole,
   FeedbackType,
 } from "@ragbits/api-client-react";
-import { useConfigContext } from "../../src/core/contexts/ConfigContext/useConfigContext";
 import { ConfigContextProvider } from "../../src/core/contexts/ConfigContext/ConfigContextProvider";
 import userEvent from "@testing-library/user-event";
 import PromptInput from "../../src/core/components/inputs/PromptInput/PromptInput";
@@ -61,69 +59,6 @@ historyStore.getState()._internal._setHasHydrated(true);
 
 describe("Integration tests", () => {
   const BASE_URL = "http://127.0.0.1:8000";
-  const renderWithHook = <R,>(hook: () => R) => {
-    return renderHook(() => hook(), {
-      wrapper: ({ children }: { children: React.ReactNode }) => {
-        return (
-          <RagbitsContextProvider baseUrl={BASE_URL}>
-            <ConfigContextProvider>{children}</ConfigContextProvider>
-          </RagbitsContextProvider>
-        );
-      },
-    });
-  };
-  /**
-   * This should test all default endpoints from the API
-   * using UIs mechanims
-   */
-  describe("/api/config", () => {
-    it("should return config", async () => {
-      // TODO: Automate generation of this test
-      const { result } = renderWithHook(() => useConfigContext());
-
-      await waitFor(() => {
-        expect(result.current).not.toBeNull();
-      });
-
-      const config = result.current.config;
-      // Customization
-      expect(config).toHaveProperty("customization");
-      // Debug mode
-      expect(config).toHaveProperty("debug_mode");
-      expect(typeof config.debug_mode).toBe("boolean");
-      // History mode
-      expect(config).toHaveProperty("conversation_history");
-      expect(typeof config.conversation_history).toBe("boolean");
-      // Authentication
-      expect(typeof config.authentication).toBe("object");
-      expect(typeof config.authentication.enabled).toBe("boolean");
-      expect(Array.isArray(config.authentication.auth_types)).toBe(true);
-      // Usage
-      expect(config).toHaveProperty("show_usage");
-      expect(typeof config.show_usage).toBe("boolean");
-
-      // Feedback
-      expect(config).toHaveProperty("feedback");
-      expect(config.feedback).toHaveProperty(FeedbackType.Like);
-      expect(config.feedback).toHaveProperty("like");
-      expect(config.feedback.like).toHaveProperty("enabled");
-      expect(typeof config.feedback.like.enabled === "boolean").toBe(true);
-      expect(config.feedback.like).toHaveProperty("form");
-      expect(
-        config.feedback.like.form === null ||
-          config.feedback.like.form instanceof Object,
-      ).toBe(true);
-
-      expect(config.feedback).toHaveProperty(FeedbackType.Dislike);
-      expect(config.feedback.dislike).toHaveProperty("enabled");
-      expect(typeof config.feedback.dislike.enabled === "boolean").toBe(true);
-      expect(config.feedback.dislike).toHaveProperty("form");
-      expect(
-        config.feedback.dislike.form === null ||
-          config.feedback.dislike.form instanceof Object,
-      ).toBe(true);
-    });
-  });
 
   describe("/api/chat", { timeout: 30000 }, () => {
     describe("should call chat endpoint with correct data", () => {

typescript/ui/src/core/components/InitializationErrorScreen.tsx

@@ -0,0 +1,18 @@
+import { cn } from "@heroui/react";
+
+export default function InitializationErrorScreen() {
+  return (
+    <div
+      className={cn(
+        "bg-background flex h-screen w-screen items-start justify-center",
+      )}
+    >
+      <div className="text-default-900 m-auto flex flex-col items-center gap-4">
+        <p className="text-large">
+          Something went wrong during chat initialization.
+        </p>
+        <p className="text-small text-default-500">Try refreshing the page.</p>
+      </div>
+    </div>
+  );
+}

typescript/ui/src/core/contexts/ConfigContext/ConfigContextProvider.tsx

@@ -1,7 +1,6 @@
 import { PropsWithChildren, useEffect, useLayoutEffect, useMemo } from "react";
 import { ConfigContext } from "./ConfigContext";
 import { useRagbitsCall } from "@ragbits/api-client-react";
-import { cn } from "@heroui/react";
 import { FeedbackFormPluginName } from "../../../plugins/FeedbackPlugin";
 import { ChatOptionsPluginName } from "../../../plugins/ChatOptionsPlugin";
 import { pluginManager } from "../../utils/plugins/PluginManager";
@@ -12,6 +11,7 @@ import { CONFIG_LOADING_PAGE_TITLE } from "../../../config";
 import { AuthPluginName } from "../../../plugins/AuthPlugin";
 import { UsagePluginName } from "../../../plugins/UsagePlugin";
 import InitializationScreen from "../../components/InitializationScreen";
+import InitializationErrorScreen from "../../components/InitializationErrorScreen";
 
 export function ConfigContextProvider({ children }: PropsWithChildren) {
   const { call: fetchConfig, ...config } = useRagbitsCall("/api/config");
@@ -66,28 +66,12 @@ export function ConfigContextProvider({ children }: PropsWithChildren) {
     document.title = CONFIG_LOADING_PAGE_TITLE;
   }, []);
 
-  // TODO: Consider adding minimal timeout for config to not flash users with this screen
   if (config.isLoading) {
     return <InitializationScreen />;
   }
 
   if (config.error || !value) {
-    return (
-      <div
-        className={cn(
-          "bg-background flex h-screen w-screen items-start justify-center",
-        )}
-      >
-        <div className="text-default-900 m-auto flex flex-col items-center gap-4">
-          <p className="text-large">
-            Something went wrong during chat initialization.
-          </p>
-          <p className="text-small text-default-500">
-            Try refreshing the page.
-          </p>
-        </div>
-      </div>
-    );
+    return <InitializationErrorScreen />;
   }
 
   return (