Skip to content

fix: Expose MarkdownHeaderLevelInferrer in preprocessors module and fix example #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Expose MarkdownHeaderLevelInferrer in preprocessors module and fix example #384

wants to merge 3 commits into from

Conversation

@julian-risch
Copy link
Member

Related Issues

  • None

Proposed Changes:

  • Add MarkdownHeaderLevelInferrer to preprocessors/__init__.py file in the same way as EmbeddingBasedDocumentSplitter
  • Fix the example code input and output
  • Simplify import path used in tests

How did you test it?

  • Ran the example locally with the updated import path
  • Changed the import path in the tests

Notes for the reviewer

Checklist

@julian-risch julian-risch requested a review from a team as a code owner October 21, 2025 07:52
@julian-risch julian-risch requested review from sjrl and removed request for a team October 21, 2025 07:52
sjrl
sjrl approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18676850930

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.54%
Totals Coverage Status
Change from base Build 18668598676: 0.0%
Covered Lines: 1123
Relevant Lines: 1592
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julian-risch @coveralls @sjrl