Skip to content

Commit 768583d

Browse files
authored
chore: disable Windows ES tests on CI (#3220)
* disable Windows ES tests * Add comments
1 parent df1f420 commit 768583d

File tree

1 file changed

+78
-76
lines changed

1 file changed

+78
-76
lines changed

.github/workflows/tests.yml

Lines changed: 78 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -251,43 +251,44 @@ jobs:
251251
channel: '#haystack'
252252
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
253253

254-
elasticsearch-tests-windows:
255-
needs:
256-
- mypy
257-
- pylint
258-
runs-on: windows-latest
259-
if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
254+
# FIXME Disabled due to #3219
255+
# elasticsearch-tests-windows:
256+
# needs:
257+
# - mypy
258+
# - pylint
259+
# runs-on: windows-latest
260+
# if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
260261

261-
steps:
262-
- uses: actions/checkout@v2
262+
# steps:
263+
# - uses: actions/checkout@v2
263264

264-
- name: Set up Elasticsearch and pdftotext
265-
run: |
266-
choco install xpdf-utils
267-
choco install openjdk11
268-
refreshenv
269-
choco install elasticsearch --version=7.9.2
270-
refreshenv
271-
Get-Service elasticsearch-service-x64 | Start-Service
272-
- name: Install Haystack
273-
run: pip install .
265+
# - name: Set up Elasticsearch and pdftotext
266+
# run: |
267+
# choco install xpdf-utils
268+
# choco install openjdk11
269+
# refreshenv
270+
# choco install elasticsearch --version=7.9.2
271+
# refreshenv
272+
# Get-Service elasticsearch-service-x64 | Start-Service
273+
# - name: Install Haystack
274+
# run: pip install .
274275

275-
- name: Setup Python
276-
uses: ./.github/actions/python_cache/
277-
with:
278-
prefix: windows
276+
# - name: Setup Python
277+
# uses: ./.github/actions/python_cache/
278+
# with:
279+
# prefix: windows
279280

280-
- name: Run tests
281-
env:
282-
TOKENIZERS_PARALLELISM: 'false'
283-
run: |
284-
pytest ${{ env.PYTEST_PARAMS }} -m "elasticsearch and not integration" test/document_stores/ ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} --document_store_type=elasticsearch
281+
# - name: Run tests
282+
# env:
283+
# TOKENIZERS_PARALLELISM: 'false'
284+
# run: |
285+
# pytest ${{ env.PYTEST_PARAMS }} -m "elasticsearch and not integration" test/document_stores/ ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} --document_store_type=elasticsearch
285286

286-
- uses: act10ns/slack@v1
287-
with:
288-
status: ${{ job.status }}
289-
channel: '#haystack'
290-
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
287+
# - uses: act10ns/slack@v1
288+
# with:
289+
# status: ${{ job.status }}
290+
# channel: '#haystack'
291+
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
291292

292293
faiss-tests-linux:
293294
needs:
@@ -711,53 +712,54 @@ jobs:
711712
channel: '#haystack'
712713
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
713714

714-
integration-tests-windows:
715-
needs:
716-
- unit-tests-windows
717-
- elasticsearch-tests-windows
718-
runs-on: windows-latest
719-
if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
720-
721-
timeout-minutes: 30
722-
strategy:
723-
fail-fast: false # Avoid cancelling the others if one of these fails
724-
matrix:
725-
folder:
726-
- "nodes"
727-
- "pipelines"
728-
- "modeling"
729-
- "others"
715+
# FIXME Disabled due to #3219
716+
# integration-tests-windows:
717+
# needs:
718+
# - unit-tests-windows
719+
# - elasticsearch-tests-windows
720+
# runs-on: windows-latest
721+
# if: contains(github.event.pull_request.labels.*.name, 'topic:windows') || !github.event.pull_request.draft
722+
723+
# timeout-minutes: 30
724+
# strategy:
725+
# fail-fast: false # Avoid cancelling the others if one of these fails
726+
# matrix:
727+
# folder:
728+
# - "nodes"
729+
# - "pipelines"
730+
# - "modeling"
731+
# - "others"
730732

731-
steps:
732-
- uses: actions/checkout@v2
733+
# steps:
734+
# - uses: actions/checkout@v2
733735

734-
- name: Set up Elasticsearch and pdftotext
735-
run: |
736-
choco install xpdf-utils
737-
choco install openjdk11
738-
refreshenv
739-
choco install tesseract --pre
740-
choco install elasticsearch --version=7.9.2
741-
refreshenv
742-
Get-Service elasticsearch-service-x64 | Start-Service
736+
# - name: Set up Elasticsearch and pdftotext
737+
# run: |
738+
# choco install xpdf-utils
739+
# choco install openjdk11
740+
# refreshenv
741+
# choco install tesseract --pre
742+
# choco install elasticsearch --version=7.9.2
743+
# refreshenv
744+
# Get-Service elasticsearch-service-x64 | Start-Service
743745

744-
- name: Setup Python
745-
uses: ./.github/actions/python_cache/
746-
with:
747-
prefix: windows
746+
# - name: Setup Python
747+
# uses: ./.github/actions/python_cache/
748+
# with:
749+
# prefix: windows
748750

749-
- name: Install Haystack
750-
run: pip install .
751+
# - name: Install Haystack
752+
# run: pip install .
751753

752-
- name: Run tests
753-
env:
754-
TOKENIZERS_PARALLELISM: 'false' # Avoid logspam by tokenizers
755-
# FIXME many tests are disabled here!
756-
run: |
757-
pytest ${{ env.PYTEST_PARAMS }} -m "integration and not tika and not graphdb" ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} test/${{ matrix.folder }} --document_store_type=memory,faiss,elasticsearch
754+
# - name: Run tests
755+
# env:
756+
# TOKENIZERS_PARALLELISM: 'false' # Avoid logspam by tokenizers
757+
# # FIXME many tests are disabled here!
758+
# run: |
759+
# pytest ${{ env.PYTEST_PARAMS }} -m "integration and not tika and not graphdb" ${{ env.SUITES_EXCLUDED_FROM_WINDOWS }} test/${{ matrix.folder }} --document_store_type=memory,faiss,elasticsearch
758760

759-
- uses: act10ns/slack@v1
760-
with:
761-
status: ${{ job.status }}
762-
channel: '#haystack'
763-
if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'
761+
# - uses: act10ns/slack@v1
762+
# with:
763+
# status: ${{ job.status }}
764+
# channel: '#haystack'
765+
# if: failure() && github.repository_owner == 'deepset-ai' && github.ref == 'refs/heads/main'

0 commit comments

Comments
 (0)