Skip to content

Commit 794fe5f

Browse files
bug: didn't clean up model files after running pytest for test_table_text_retriever_training (#3534)
* Added tmp path to avoid clean up of model files later
1 parent 255072d commit 794fe5f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/nodes/test_retriever.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ def sum_params(model):
424424

425425

426426
@pytest.mark.embedding_dim(128)
427-
def test_table_text_retriever_training(document_store):
427+
def test_table_text_retriever_training(tmp_path, document_store):
428428
retriever = TableTextRetriever(
429429
document_store=document_store,
430430
query_embedding_model="deepset/bert-small-mm_retrieval-question_encoder",
@@ -438,11 +438,13 @@ def test_table_text_retriever_training(document_store):
438438
train_filename="sample.json",
439439
n_epochs=1,
440440
n_gpu=0,
441-
save_dir="test_table_text_retriever_train",
441+
save_dir=f"{tmp_path}/test_table_text_retriever_train",
442442
)
443443

444444
# Load trained model
445-
retriever = TableTextRetriever.load(load_dir="test_table_text_retriever_train", document_store=document_store)
445+
retriever = TableTextRetriever.load(
446+
load_dir=f"{tmp_path}/test_table_text_retriever_train", document_store=document_store
447+
)
446448

447449

448450
@pytest.mark.elasticsearch

0 commit comments

Comments
 (0)