Skip to content

Commit f4ae669

Browse files
deevusclaude
andcommitted
fix: rename snapshot test files so featurematrix detects them
Rename snapshot_query_test.go → snapshot_service_query_test.go and snapshot_rollback_test.go → snapshot_service_rollback_test.go so the featurematrix scanner finds them (requires _service in filename). Regenerate FEATURES.md — back to 100% test coverage of implemented methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f1cc334 commit f4ae669

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

FEATURES.md

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
TrueNAS version: 25.04
44

5-
Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemented)
5+
Total API methods: 771 | Implemented: 72 (9.3%) | Tested: 72 (100.0% of implemented)
66

77
## Covered Namespaces
88

@@ -15,11 +15,12 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
1515
| DockerService | docker | 8 | 2 (25%) | 2 (100%) |
1616
| FilesystemService | filesystem | 13 | 2 (15%) | 2 (100%) |
1717
| InterfaceService | interface | 23 | 1 (4%) | 1 (100%) |
18+
| NetworkService | network.general | 1 | 1 (100%) | 1 (100%) |
1819
| ReportingService | reporting | 8 | 2 (25%) | 2 (100%) |
19-
| SnapshotService | zfs.snapshot | 9 | 6 (67%) | 6 (100%) |
20+
| SnapshotService | zfs.snapshot | 9 | 7 (78%) | 7 (100%) |
2021
| SystemService | system | 14 | 2 (14%) | 2 (100%) |
2122
| VMService | vm, vm.device | 51 | 10 (20%) | 10 (100%) |
22-
| VirtService | virt.global, virt.instance | 18 | 11 (61%) | 11 (100%) |
23+
| VirtService | virt.global, virt.instance | 18 | 12 (67%) | 12 (100%) |
2324

2425
### AppService — `app` (28 methods)
2526

@@ -234,6 +235,12 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
234235
| interface.websocket_local_ip | | | | |
235236
| interface.xmit_hash_policy_choices | | | | |
236237

238+
### NetworkService — `network.general` (1 methods)
239+
240+
| API Method | Implemented | Go Method | Tested | Tests |
241+
|------------|:-----------:|-----------|:------:|------:|
242+
| network.general.summary || GetSummary || 5 |
243+
237244
### ReportingService — `reporting` (8 methods)
238245

239246
| API Method | Implemented | Go Method | Tested | Tests |
@@ -256,9 +263,9 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
256263
| zfs.snapshot.delete || Delete || 2 |
257264
| zfs.snapshot.get_instance | | | | |
258265
| zfs.snapshot.hold || Hold || 2 |
259-
| zfs.snapshot.query || Get, List || 9 |
266+
| zfs.snapshot.query || Get, List, Query || 15 |
260267
| zfs.snapshot.release || Release || 2 |
261-
| zfs.snapshot.rollback | | | | |
268+
| zfs.snapshot.rollback | | Rollback | | 3 |
262269
| zfs.snapshot.update | | | | |
263270

264271
### SystemService — `system` (14 methods)
@@ -346,7 +353,7 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
346353
| API Method | Implemented | Go Method | Tested | Tests |
347354
|------------|:-----------:|-----------|:------:|------:|
348355
| virt.global.bridge_choices | | | | |
349-
| virt.global.config || GetGlobalConfig || 4 |
356+
| virt.global.config || GetGlobalConfig || 6 |
350357
| virt.global.get_network | | | | |
351358
| virt.global.pool_choices | | | | |
352359
| virt.global.update || UpdateGlobalConfig || 3 |
@@ -363,13 +370,13 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
363370
| virt.instance.device_update | | | | |
364371
| virt.instance.get_instance || GetInstance || 4 |
365372
| virt.instance.image_choices | | | | |
366-
| virt.instance.query | | | | |
373+
| virt.instance.query | | ListInstances | | 5 |
367374
| virt.instance.restart | | | | |
368375
| virt.instance.start || StartInstance || 2 |
369376
| virt.instance.stop || StopInstance || 3 |
370377
| virt.instance.update || UpdateInstance || 3 |
371378

372-
## Uncovered Namespaces (96 namespaces, 513 methods)
379+
## Uncovered Namespaces (95 namespaces, 512 methods)
373380

374381
| Namespace | Methods |
375382
|-----------|--------:|
@@ -430,7 +437,6 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
430437
| ldap | 4 |
431438
| mail | 4 |
432439
| network.configuration | 3 |
433-
| network.general | 1 |
434440
| nfs | 6 |
435441
| pool.resilver | 2 |
436442
| pool.scrub | 7 |
@@ -470,7 +476,7 @@ Total API methods: 771 | Implemented: 69 (8.9%) | Tested: 69 (100.0% of implemen
470476
| virt.volume | 7 |
471477
| vmware | 8 |
472478

473-
## Go Methods Not in API Schema (10 methods)
479+
## Go Methods Not in API Schema (13 methods)
474480

475481
These Go methods call API endpoints not present in the 25.04 method schema
476482
(e.g., subscription/event channels, version-specific aliases).
@@ -479,12 +485,15 @@ These Go methods call API endpoints not present in the 25.04 method schema
479485
|------------|-----------|------------|
480486
| AppService | SubscribeContainerLogs | app.container_log_follow |
481487
| AppService | SubscribeStats | app.stats |
488+
| FilesystemService | WriteFile | filesystem.file_receive |
482489
| ReportingService | SubscribeRealtime | reporting.realtime |
483490
| SnapshotService | Clone | pool.snapshot.clone |
484491
| SnapshotService | Create | pool.snapshot.create |
485492
| SnapshotService | Delete | pool.snapshot.delete |
486493
| SnapshotService | Hold | pool.snapshot.hold |
487-
| SnapshotService | Get | pool.snapshot.query |
488494
| SnapshotService | List | pool.snapshot.query |
495+
| SnapshotService | Query | pool.snapshot.query |
496+
| SnapshotService | Get | pool.snapshot.query |
489497
| SnapshotService | Release | pool.snapshot.release |
498+
| SnapshotService | Rollback | pool.snapshot.rollback |
490499

0 commit comments

Comments
 (0)