Skip to content

Commit a958cd6

Browse files
committed
Remove test that fails on WebKit due to bizzare iframe bug
The test verifies that, in an iframe, we can navigate to another page and then press browser's Back button to restore the previous page. However, on Chrome and Safari in pjax-disabled mode (browser native behavior) doing `frame.history.back()` actually goes back in the top frame, effectively navigating away from the test suite that's running. There doesn't seem a way to carefully sandbox browser history navigation to just inside the iframe. Because this test has the potential to intermittently screw up the whole test suite run, 🔥 it without mercy as I've already spent countless hours trying to debug this and have better things to do with my life.
1 parent 8de14eb commit a958cd6

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

test/unit/pjax_fallback.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -99,33 +99,6 @@ asyncTest("sends correct HTTP referer"+s, function() {
9999
})
100100
})
101101

102-
asyncTest("adds entry to browser history"+s, function() {
103-
var frame = this.frame
104-
var count = 0
105-
106-
frame.onpopstate = function() {
107-
window.iframeLoad(frame)
108-
}
109-
110-
this.loaded = function() {
111-
count++
112-
113-
if (count == 1) {
114-
equal(frame.location.pathname, "/hello.html")
115-
ok(frame.history.length > 1)
116-
frame.history.back()
117-
} else if (count == 2) {
118-
equal(frame.location.pathname, "/home.html")
119-
start()
120-
}
121-
}
122-
123-
frame.$.pjax({
124-
url: "hello.html",
125-
container: "#main"
126-
})
127-
})
128-
129102
asyncTest("scrolls to top of the page"+s, function() {
130103
var frame = this.frame
131104

0 commit comments

Comments
 (0)