Added max token_ids length validation method for the OrdersEndpoint.

Author: dehidehidehi

open_sea_v1/endpoints/client.py

@@ -49,6 +49,7 @@ def _set_max_rate_limit(self) -> None:
         if self.api_key:
             raise NotImplementedError("I don't know what the rate limit is for calls with an API key is yet.")
 
+
 @dataclass
 class BaseClient(ABC):
     """
@@ -112,11 +113,17 @@ def get_pages(self) -> Generator[list[list[BaseResponse]], None, None]:
 
         while self.remaining_pages():
             self._http_response = self._get_request()
+            self.check_if_response_is_valid()
             if self.parsed_http_response is not None:  # edge case
                 self.processed_pages += 1
                 self.client_params.offset += self.client_params.page_size
                 yield self.parsed_http_response
 
+    def check_if_response_is_valid(self):
+        if not self._http_response.ok:
+            logger.warning(f'Page {self.processed_pages} returned a {self._http_response.status_code} status code: {self._http_response.reason}\n'
+                           f'{self._http_response.text}')
+
     def remaining_pages(self) -> bool:
         if self._http_response is None:
             return True

open_sea_v1/endpoints/orders.py

@@ -119,11 +119,7 @@ def url(self):
 
     @property
     def parsed_http_response(self) -> list[OrderResponse]:
-        if self._http_response:
-            orders_jsons = self._http_response.json()['orders']
-            orders = [OrderResponse(order_json) for order_json in orders_jsons]
-            return orders
-        return list()
+        return self.parse_http_response(OrderResponse, 'orders')
 
     def _get_request(self, **kwargs):
         params = dict(
@@ -160,6 +156,7 @@ def _validate_request_params(self) -> None:
         self._validate_contract_address_defined_with_token_id_or_tokens_ids()
         self._validate_token_id_defined_with_contract_address()
         self._validate_token_ids_defined_with_contract_address()
+        self._validate_token_ids_quantity_is_lower_or_equal_to_30()
         self._validate_token_id_and_token_ids_cannot_be_defined_together()
         self._validate_listed_after_and_listed_before_are_datetimes()
         self._validate_order_by_eth_price_is_defined_with_asset_contract_address_and_token_id_or_token_ids()
@@ -180,6 +177,10 @@ def _validate_token_id_defined_with_contract_address(self) -> None:
         if not self.asset_contract_address:
             raise AttributeError('Attribute token_id must be defined together with asset_contract_address')
 
+    def _validate_token_ids_quantity_is_lower_or_equal_to_30(self):
+        if self.token_ids and len(self.token_ids) > 30:
+            raise ValueError('Attribute token_ids length must be equal or below 30.')
+
     def _validate_token_ids_defined_with_contract_address(self) -> None:
         if self.token_ids is None:
             return

open_sea_v1/endpoints/tests/test_orders.py

@@ -42,6 +42,10 @@ def test_attr_token_id_raises_if_not_defined_together_with_asset_contract_addres
         self.endpoint_kwargs |= dict(token_id=self.token_id)
         self.assertRaises(AttributeError, OrdersEndpoint, **self.endpoint_kwargs)
 
+    def test_attr_token_ids_raises_if_len_is_above_30(self):
+        self.endpoint_kwargs |= dict(asset_contract_address=self.asset_contract_address, token_ids=list(range(1, 32)))
+        self.assertRaises(ValueError, OrdersEndpoint, **self.endpoint_kwargs)
+
     def test_attr_token_ids_raises_if_not_defined_together_with_asset_contract_address(self):
         self.endpoint_kwargs |= dict(token_ids=[self.token_id, self.token_id_2])
         self.assertRaises(AttributeError, OrdersEndpoint, **self.endpoint_kwargs)

open_sea_v1/responses/order.py

@@ -14,7 +14,7 @@ class OrderResponse(BaseResponse):
     _json: dict
 
     def __str__(self):
-        return f"order_id={self.id}"
+        return f"order_id={self.id}     {str(self.asset)}"
 
     def __post_init__(self):
         self._set_common_attrs()