Hotfix: removed token_id as a possible order_by parameter for Asset endpoint.

Author: dehidehidehi

open_sea_v1/endpoints/assets.py

@@ -12,12 +12,16 @@ class AssetsOrderBy(str, Enum):
     """
     Helper Enum for remembering the possible values for the order_by param of the AssetsEndpoint class.
     """
-    TOKEN_ID = "token_id"
     SALE_DATE = "sale_date"
     SALE_COUNT = "sale_count"
     VISITOR_COUNT = "visitor_count"
     SALE_PRICE = "sale_price"
 
+    @classmethod
+    def list(cls) -> list[str]:
+        """Returns list of values of each attribute of this String Enum."""
+        return list(map(lambda c: c.value, cls))
+
 
 @dataclass
 class AssetsEndpoint(BaseClient, BaseEndpoint):
@@ -129,7 +133,7 @@ def _validate_order_by(self) -> None:
         if self.order_by is None:
             return
 
-        if self.order_by not in (AssetsOrderBy.TOKEN_ID, AssetsOrderBy.SALE_COUNT, AssetsOrderBy.SALE_DATE, AssetsOrderBy.SALE_PRICE, AssetsOrderBy.VISITOR_COUNT):
+        if self.order_by not in AssetsOrderBy.list():
             raise ValueError(
                 f"order_by param value ({self.order_by}) is invalid. "
                 f"Must be a value from {AssetsOrderBy.list()}, case sensitive."

open_sea_v1/endpoints/tests/test_assets.py

@@ -49,11 +49,6 @@ def test_param_order_direction_can_only_be_asc_or_desc(self):
             params = dict(token_ids=[1], asset_contract_address=self.sample_contract, order_direction=invalid_order)
             self.assertRaises((ValueError, TypeError), AssetsEndpoint, **params)
 
-    def test_param_order_by_token_id(self):
-        params = self.default_asset_params | dict(token_ids=[3, 2, 1], order_by=AssetsOrderBy.TOKEN_ID, order_direction='desc')
-        punks_ids = [punk.token_id for punk in self.create_and_get(**params)]
-        self.assertEqual(['3', '2', '1'], punks_ids)
-
     def test_param_order_by_sale_date(self):
         params = self.default_asset_params | dict(token_ids=[1, 14, 33], order_by=AssetsOrderBy.SALE_DATE)
         punks_sales = [punk.last_sale.event_timestamp for punk in self.create_and_get(**params)]