chore: Use cloneable ptr to default copy ctor && assignment (acts-project#5119)

Simplify surface copy constructor && assignment operator

Author: junggjo9

Core/include/Acts/Surfaces/Surface.hpp

@@ -19,6 +19,7 @@
 #include "Acts/Surfaces/BoundaryTolerance.hpp"
 #include "Acts/Surfaces/SurfaceBounds.hpp"
 #include "Acts/Surfaces/SurfacePlacementBase.hpp"
+#include "Acts/Utilities/CloneablePtr.hpp"
 #include "Acts/Utilities/Intersection.hpp"
 #include "Acts/Utilities/Result.hpp"
 #include "Acts/Visualization/ViewConfig.hpp"
@@ -89,7 +90,7 @@ class Surface : public virtual GeometryObject,
   /// to detector element and layer
   ///
   /// @param other Source surface for copy.
-  Surface(const Surface& other) noexcept;
+  Surface(const Surface& other) noexcept = default;
 
   /// Constructor from SurfacePlacement: Element proxy
   ///
@@ -153,7 +154,7 @@ class Surface : public virtual GeometryObject,
   ///
   /// @param other Source surface for the assignment
   /// @return Reference to this surface after assignment
-  Surface& operator=(const Surface& other);
+  Surface& operator=(const Surface& other) noexcept = default;
 
   /// Comparison (equality) operator
   /// The strategy for comparison is
@@ -563,7 +564,7 @@ class Surface : public virtual GeometryObject,
 
   /// Transform3 definition that positions
   /// (translation, rotation) the surface in global space
-  std::unique_ptr<const Transform3> m_transform{};
+  CloneablePtr<const Transform3> m_transform{};
 
  private:
   /// Pointer to the a SurfacePlacement

Core/src/Surfaces/Surface.cpp

@@ -26,16 +26,6 @@ Surface::Surface(const Transform3& transform)
 Surface::Surface(const SurfacePlacementBase& placement) noexcept
     : GeometryObject(), m_placement(&placement) {}
 
-Surface::Surface(const Surface& other) noexcept
-    : GeometryObject(other),
-      std::enable_shared_from_this<Surface>(),
-      m_placement(other.m_placement),
-      m_surfaceMaterial(other.m_surfaceMaterial) {
-  if (other.m_transform) {
-    m_transform = std::make_unique<Transform3>(*other.m_transform);
-  }
-}
-
 Surface::Surface(const GeometryContext& gctx, const Surface& other,
                  const Transform3& shift) noexcept
     : GeometryObject(),
@@ -158,23 +148,6 @@ std::shared_ptr<const Surface> Surface::getSharedPtr() const {
   return shared_from_this();
 }
 
-Surface& Surface::operator=(const Surface& other) {
-  if (&other != this) {
-    GeometryObject::operator=(other);
-    // detector element, identifier & layer association are unique
-    if (other.m_transform) {
-      m_transform = std::make_unique<Transform3>(*other.m_transform);
-    } else {
-      m_transform.reset();
-    }
-    m_associatedLayer = other.m_associatedLayer;
-    m_surfaceMaterial = other.m_surfaceMaterial;
-    m_placement = other.m_placement;
-    m_isSensitive = other.m_isSensitive;
-  }
-  return *this;
-}
-
 bool Surface::operator==(const Surface& other) const {
   // (a) fast exit for pointer comparison
   if (&other == this) {
@@ -241,9 +214,7 @@ std::string Surface::toString(const GeometryContext& gctx) const {
 }
 
 Vector3 Surface::center(const GeometryContext& gctx) const {
-  // fast access via transform matrix (and not translation())
-  auto tMatrix = localToGlobalTransform(gctx).matrix();
-  return Vector3(tMatrix(0, 3), tMatrix(1, 3), tMatrix(2, 3));
+  return localToGlobalTransform(gctx).translation();
 }
 
 const Transform3& Surface::transform(const GeometryContext& gctx) const {