feat: undepracate ArrayData.array_elements() (#1493)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-incubator/delta-kernel-rs/blob/main/CONTRIBUTING.md
2. Run `cargo t --all-features --all-targets` to get started testing,
and run `cargo fmt`.
  3. Ensure you have added or run the appropriate tests for your PR.
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  5. Be sure to keep the PR description updated to reflect all changes.
-->

<!--
PR title formatting:
This project uses conventional commits:
https://www.conventionalcommits.org/

Each PR corresponds to a commit on the `main` branch, with the title of
the PR (typically) being
used for the commit message on main. In order to ensure proper
formatting in the CHANGELOG please
ensure your PR title adheres to the conventional commit specification.

Examples:
- new feature PR: "feat: new API for snapshot.update()"
- bugfix PR: "fix: correctly apply DV in read-table example"
-->

## What changes are proposed in this pull request?
Fixes #1197
<!--
Please clarify what changes you are proposing and why the changes are
needed.
The purpose of this section is to outline the changes, why they are
needed, and how this PR fixes the issue.
If the reason for the change is already explained clearly in an issue,
then it does not need to be restated here.
1. If you propose a new API or feature, clarify the use case for a new
API or feature.
  2. If you fix a bug, you can clarify why it is a bug.
-->

<!--
Uncomment this section if there are any changes affecting public APIs:
### This PR affects the following public APIs

If there are breaking changes, please ensure the `breaking-changes`
label gets added by CI, and describe why the changes are needed.

Note that _new_ public APIs are not considered breaking.
-->


## How was this change tested?
<!--
Please make sure to add test cases that check the changes thoroughly
including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please
clarify how you tested, ideally via a reproducible test documented in
the PR description.
-->

Co-authored-by: aleksandarskrbic <[email protected]>
Co-authored-by: Zach Schuermann <[email protected]>

Author: aleksandarskrbic

ffi/src/expressions/engine_visitor.rs

@@ -317,7 +317,6 @@ fn visit_expression_array(
     array: &ArrayData,
     sibling_list_id: usize,
 ) {
-    #[allow(deprecated)]
     let elements = array.array_elements();
     let child_list_id = call!(visitor, make_field_list, elements.len());
     for scalar in elements {

kernel/src/engine/arrow_expression/evaluate_expression.rs

@@ -380,7 +380,6 @@ pub fn evaluate_predicate(
                     }
                 }
                 (Expression::Literal(lit), Expression::Literal(Scalar::Array(ad))) => {
-                    #[allow(deprecated)]
                     let exists = ad.array_elements().contains(lit);
                     Ok(BooleanArray::from(vec![exists]))
                 }

kernel/src/engine/arrow_expression/mod.rs

@@ -113,7 +113,6 @@ impl Scalar {
             Array(data) => {
                 let builder = builder_as!(array::ListBuilder<Box<dyn ArrayBuilder>>);
                 for _ in 0..num_rows {
-                    #[allow(deprecated)]
                     for value in data.array_elements() {
                         value.append_to(builder.values(), 1)?;
                     }
@@ -218,7 +217,6 @@ impl ArrayData {
     pub fn to_arrow(&self) -> DeltaResult<ArrayRef> {
         let arrow_data_type = ArrowDataType::try_from_kernel(self.array_type().element_type())?;
 
-        #[allow(deprecated)]
         let elements = self.array_elements();
         let mut builder = array::make_builder(&arrow_data_type, elements.len());
         for element in elements {

kernel/src/expressions/scalars.rs

@@ -94,9 +94,6 @@ impl ArrayData {
         &self.tpe
     }
 
-    #[deprecated(
-        note = "These fields will be removed eventually and are unstable. See https://github.com/delta-io/delta-kernel-rs/issues/291"
-    )]
     pub fn array_elements(&self) -> &[Scalar] {
         &self.elements
     }
@@ -923,7 +920,6 @@ mod tests {
 
     #[test]
     fn test_arrays() {
-        #[allow(deprecated)]
         let array = Scalar::Array(ArrayData {
             tpe: ArrayType::new(DataType::INTEGER, false),
             elements: vec![Scalar::Integer(1), Scalar::Integer(2), Scalar::Integer(3)],
@@ -1173,7 +1169,6 @@ mod tests {
         let Scalar::Array(array_data) = scalar else {
             panic!("Expected Array scalar");
         };
-        #[allow(deprecated)]
         let elements = array_data.array_elements();
         assert_eq!(elements.len(), 3);
         assert!(!array_data.array_type().contains_null());
@@ -1206,7 +1201,6 @@ mod tests {
             panic!("Expected Array scalar");
         };
 
-        #[allow(deprecated)]
         let elements = array_data.array_elements();
         assert_eq!(elements.len(), 3);
         assert!(array_data.array_type().contains_null());