Skip to content

Commit 167cf6a

Browse files
committed
Fixes + warning
Signed-off-by: Peter Ke <[email protected]>
1 parent a46391f commit 167cf6a

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

python/deltalake/_internal.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@ class DeltaFileSystemHandler:
875875

876876
class PyQueryBuilder:
877877
def __init__(self) -> None: ...
878-
def register(self, table_name: str, delta_table: RawDeltaTable): ...
878+
def register(self, table_name: str, delta_table: RawDeltaTable) -> None: ...
879879
def execute(self, sql: str) -> List[pyarrow.RecordBatch]: ...
880880

881881
class DeltaDataChecker:

python/deltalake/query.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,21 @@
11
from __future__ import annotations
22

3+
import warnings
34
from typing import List
45

56
import pyarrow
67

78
from deltalake._internal import PyQueryBuilder
89
from deltalake.table import DeltaTable
10+
from deltalake.warnings import ExperimentalWarning
911

1012

1113
class QueryBuilder:
1214
def __init__(self) -> None:
15+
warnings.warn(
16+
"QueryBuilder is experimental and subject to change",
17+
category=ExperimentalWarning,
18+
)
1319
self._query_builder = PyQueryBuilder()
1420

1521
def register(self, table_name: str, delta_table: DeltaTable) -> QueryBuilder:

python/deltalake/warnings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
class ExperimentalWarning(Warning):
2+
pass

python/src/query.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ impl PyQueryBuilder {
2929
let log_store = delta_table._table.log_store();
3030

3131
let scan_config = DeltaScanConfigBuilder::default()
32-
.with_parquet_pushdown(false)
3332
.build(snapshot)
3433
.map_err(PythonError::from)?;
3534

0 commit comments

Comments
 (0)