chore: latest clippy

Signed-off-by: Robert Pack <[email protected]>

Author: roeap

crates/core/src/kernel/arrow/engine_ext.rs

@@ -118,7 +118,7 @@ fn stats_schema(
     mut min_max_transform: MinMaxStatsTransform,
 ) -> DeltaResult<SchemaRef> {
     let min_max_schema =
-        if let Some(min_max_schema) = min_max_transform.transform_struct(&physical_schema) {
+        if let Some(min_max_schema) = min_max_transform.transform_struct(physical_schema) {
             min_max_schema.into_owned()
         } else {
             StructType::new(vec![])

crates/core/src/logstore/config.rs

@@ -330,7 +330,7 @@ mod tests {
         };
 
         let result: ParseResult<RetryConfig> = options.into_iter().collect();
-        println!("result: {:?}", result);
+        println!("result: {result:?}");
         assert!(!result.errors.is_empty());
         assert!(!result.unparsed.is_empty());
         assert!(!result.is_default);
@@ -381,11 +381,11 @@ mod tests {
         let falsy_values = ["0", "false", "off", "NO", "n", "bork", "False", "OFF"];
 
         for value in truthy_values {
-            assert!(str_is_truthy(value), "{} should be truthy", value);
+            assert!(str_is_truthy(value), "{value} should be truthy");
         }
 
         for value in falsy_values {
-            assert!(!str_is_truthy(value), "{} should be falsy", value);
+            assert!(!str_is_truthy(value), "{value} should be falsy");
         }
     }
 

crates/core/src/logstore/mod.rs

@@ -674,7 +674,7 @@ pub async fn get_latest_version(
     .map_err(|e| DeltaTableError::Generic(e.to_string()))?
     .map_err(|e| {
         if e.to_string()
-            .contains(&format!("to have version {}", current_version))
+            .contains(&format!("to have version {current_version}"))
         {
             DeltaTableError::InvalidVersion(current_version)
         } else {

crates/core/src/operations/merge/mod.rs

@@ -875,7 +875,7 @@ async fn execute(
         }
     };
 
-    debug!("Using target subset filter: {:?}", commit_predicate);
+    debug!("Using target subset filter: {commit_predicate:?}");
 
     let file_column = Arc::new(scan_config.file_column_name.clone().unwrap());
     // Need to manually push this filter into the scan... We want to PRUNE files not FILTER RECORDS

crates/core/src/operations/update_table_metadata.rs

@@ -113,7 +113,7 @@ impl std::future::IntoFuture for UpdateTableMetadataBuilder {
             })?;
             update
                 .validate()
-                .map_err(|e| DeltaTableError::MetadataError(format!("{}", e)))?;
+                .map_err(|e| DeltaTableError::MetadataError(format!("{e}")))?;
 
             let mut metadata = this.snapshot.metadata().clone();
 

crates/core/src/operations/write/generated_columns.rs

@@ -1,6 +1,6 @@
 use crate::table::state::DeltaTableState;
 use datafusion::common::ScalarValue;
-use datafusion::logical_expr::{col, when, Expr, ExprSchemable};
+use datafusion::logical_expr::{col, when, ExprSchemable};
 use datafusion::prelude::lit;
 use datafusion::{execution::SessionState, prelude::DataFrame};
 use delta_kernel::engine::arrow_conversion::TryIntoArrow as _;

crates/core/src/table/config.rs

@@ -388,7 +388,7 @@ impl TableConfig<'_> {
             .and_then(|o| {
                 o.as_ref().and_then(|v| {
                     ColumnName::parse_column_name_list(v)
-                        .inspect_err(|e| println!("{:?}", e))
+                        .inspect_err(|e| println!("{e:?}"))
                         .ok()
                 })
             })

crates/core/tests/dat.rs

@@ -18,7 +18,7 @@ fn reader_test_eager(path: &Path) -> datatest_stable::Result<()> {
     );
     for skipped in SKIPPED_TESTS {
         if root_dir.ends_with(skipped) {
-            println!("Skipping test: {}", skipped);
+            println!("Skipping test: {skipped}");
             return Ok(());
         }
     }

crates/core/tests/integration_datafusion.rs

@@ -304,7 +304,7 @@ mod local {
         for pp in pruning_predicates {
             let pred = pp.sql;
             let sql = format!("SELECT CAST( day as int ) as my_day FROM demo WHERE {pred} ORDER BY CAST( day as int ) ASC");
-            println!("\nExecuting query: {}", sql);
+            println!("\nExecuting query: {sql}");
 
             let df = ctx.sql(sql.as_str()).await?;
 

crates/derive/src/lib.rs

@@ -67,7 +67,7 @@ pub fn derive_delta_config(input: TokenStream) -> TokenStream {
 }
 
 fn generate_config_keys(name: &Ident, fields: &[&Field]) -> Result<proc_macro2::TokenStream> {
-    let enum_name = Ident::new(&format!("{}Key", name), Span::call_site());
+    let enum_name = Ident::new(&format!("{name}Key"), Span::call_site());
     let variants: Vec<_> = fields
         .iter()
         .map(|field| {