Skip to content

Commit 0bbfeab

Browse files
committed
Added tests for naive filter
1 parent db17ce6 commit 0bbfeab

File tree

2 files changed

+49
-0
lines changed

2 files changed

+49
-0
lines changed

src/filters/naive_filter/filter.rs

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,4 +161,52 @@ mod tests {
161161
assert_eq!(17, passed_messages);
162162
assert_eq!(83, filtered_messages);
163163
}
164+
165+
#[test]
166+
fn invalid_filters() {
167+
assert!(
168+
NaiveFilter::from_filters(&vec!["method~='get]".to_string()]).is_err(),
169+
"The filter should not have been created"
170+
);
171+
assert!(
172+
NaiveFilter::from_filters(&vec!["method~='get']".to_string()]).is_err(),
173+
"The filter should not have been created"
174+
);
175+
assert!(
176+
NaiveFilter::from_filters(&vec!["status~=`404".to_string()]).is_err(),
177+
"The filter should not have been created"
178+
);
179+
assert!(
180+
NaiveFilter::from_filters(&vec!["status~=`404,123`".to_string()]).is_err(),
181+
"The filter should not have been created"
182+
);
183+
assert!(
184+
NaiveFilter::from_filters(&vec!["status~=`abc`".to_string()]).is_err(),
185+
"The filter should not have been created"
186+
);
187+
assert!(
188+
NaiveFilter::from_filters(&vec!["status~=`abc`".to_string()]).is_err(),
189+
"The filter should not have been created"
190+
);
191+
}
192+
193+
#[test]
194+
fn valid_filters() {
195+
assert!(
196+
NaiveFilter::from_filters(&vec!["method=='get'".to_string()]).is_ok(),
197+
"The filter should have been created"
198+
);
199+
assert!(
200+
NaiveFilter::from_filters(&vec!["status==`404`".to_string()]).is_ok(),
201+
"The filter should have been created"
202+
);
203+
assert!(
204+
NaiveFilter::from_filters(&vec!["status==internal.status".to_string()]).is_ok(),
205+
"The filter should have been created"
206+
);
207+
assert!(
208+
NaiveFilter::from_filters(&vec!["internal.value!=`3.1415962`".to_string()]).is_ok(),
209+
"The filter should not have been created"
210+
);
211+
}
164212
}

src/filters/naive_filter/operand.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ impl NaiveFilterOperand {
2828
}
2929

3030
pub(crate) fn from_str(operand_str: &str) -> Result<Self, NaiveFilterError> {
31+
let operand_str = operand_str.trim();
3132
match operand_str.chars().next() {
3233
// number
3334
Some('`') => {

0 commit comments

Comments
 (0)