ApplyBumpFee only ever called for policyAsset (in wallet/spend.cpp). wallet_elements_regression_1259 test verifies bump fee is no applied for issued asset outputs.

Tom Trevethan · delta1 · commit 36e1efbe883b · 2026-01-19T15:40:41.000+02:00
(cherry picked from commit b83f46d)
diff --git a/src/wallet/coinselection.h b/src/wallet/coinselection.h
@@ -105,14 +105,15 @@ struct COutput {
         return outpoint < rhs.outpoint;
     }
 
+    // ELEMENTS: ApplyBumpFee applied only for policyAsset
     void ApplyBumpFee(CAmount bump_fee)
     {
         assert(bump_fee >= 0);
         ancestor_bump_fees = bump_fee;
         assert(fee);
         *fee += bump_fee;
         // Note: assert(effective_value - bump_fee == nValue - fee.value());
-        effective_value = value - fee.value(); // ELEMENTS FIXME
+        effective_value = value - fee.value();
     }
 
     CAmount GetFee() const

Original file line number	Diff line number	Diff line change
`@@ -105,14 +105,15 @@ struct COutput {`
`105`	`105`	`return outpoint < rhs.outpoint;`
`106`	`106`	`}`
`107`	`107`
	`108`	`+ // ELEMENTS: ApplyBumpFee applied only for policyAsset`
`108`	`109`	`void ApplyBumpFee(CAmount bump_fee)`
`109`	`110`	`{`
`110`	`111`	`assert(bump_fee >= 0);`
`111`	`112`	`ancestor_bump_fees = bump_fee;`
`112`	`113`	`assert(fee);`
`113`	`114`	`*fee += bump_fee;`
`114`	`115`	`// Note: assert(effective_value - bump_fee == nValue - fee.value());`
`115`		`- effective_value = value - fee.value(); // ELEMENTS FIXME`
	`116`	`+ effective_value = value - fee.value();`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`CAmount GetFee() const`