Skip to content

Commit dd0b0f7

Browse files
Tom Trevethandelta1
authored andcommitted
resolve fixme in p2p_segwit.py functional test: the bad-witness-merkle-match reject reason is due to the Elements-style witness structure added to the serialisation of BrokenCTransaction in ElementsProject#494 causing the CheckWitnessMalleation check to fail before reaching CheckMerkleRoot which would fail with a bad-txnmrklroot reason
(cherry picked from commit 3039060)
1 parent fe70c8b commit dd0b0f7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/functional/p2p_segwit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,7 @@ def serialize_with_witness(self):
12231223

12241224
block = self.build_next_block()
12251225
self.update_witness_block_with_transactions(block, [tx2])
1226-
test_witness_block(self.nodes[0], self.test_node, block, accepted=False, reason='bad-witness-merkle-match') # ELEMENTS: FIXME why is this reason different
1226+
test_witness_block(self.nodes[0], self.test_node, block, accepted=False, reason='bad-witness-merkle-match') # ELEMENTS: reason due to CheckWitnessMalleation and elements-style witness structure
12271227

12281228
# Now try using a too short vtxinwit
12291229
tx2.wit.vtxinwit.pop()

0 commit comments

Comments
 (0)