Merge branch 'main' into adb/media-preview-edge2edge

Author: adbenitez

.github/workflows/artifacts.yml

@@ -7,7 +7,7 @@ on:
 jobs:
   artifacts-url-comments:
     name: add artifact links to pull request
-    runs-on: windows-2019
+    runs-on: ubuntu-latest
     if: ${{ github.event.workflow_run.conclusion == 'success' }}
     steps:
       - name: add artifact links to pull request

.github/workflows/preview-apk.yml

@@ -2,27 +2,27 @@ name: Upload Preview APK
 
 on: pull_request
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
+
 jobs:
   build:
     name: Upload Preview APK
     runs-on: ubuntu-latest
     steps:
-      - name: Cancel Previous Runs
-        uses: styfle/[email protected]
-        with:
-          access_token: ${{ github.token }}
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v5
         with:
           submodules: recursive
       - uses: Swatinem/rust-cache@v2
         with:
           working-directory: jni/deltachat-core-rust
-      - uses: actions/setup-java@v3
+      - uses: actions/setup-java@v5
         with:
           java-version: 17
           distribution: 'temurin'
       - uses: android-actions/setup-android@v3
-      - uses: actions/cache@v3
+      - uses: actions/cache@v4
         with:
           path: |
             ~/.gradle/caches
@@ -35,16 +35,16 @@ jobs:
         with:
           ndk-version: r27
 
+      - name: Validate Gradle Wrapper
+        uses: gradle/actions/wrapper-validation@v4
+
       - name: Compile core
         env:
           ANDROID_NDK_ROOT: ${{ steps.setup-ndk.outputs.ndk-path }}
         run: |
           export PATH="${PATH}:${ANDROID_NDK_ROOT}/toolchains/llvm/prebuilt/linux-x86_64/bin/"
           scripts/install-toolchains.sh && scripts/ndk-make.sh
 
-      - name: Validate Gradle Wrapper
-        uses: gradle/wrapper-validation-action@v1
-
       - name: Build APK
         run: ./gradlew --no-daemon assembleGplayDebug
 

CHANGELOG.md

@@ -14,7 +14,7 @@
 * avoid "unknown sender for this chat" error
 * properly display "Messages are end-to-end encrypted." in all encrypted groups
 * several small fixes and improvements
-* update to core 2.13.0
+* update to core 2.17.0
 
 ## v2.11.0
 2025-08

README.md

@@ -23,6 +23,28 @@ subproject _deltachat-core-rust_:
   or later by `git submodule update --init --recursive`. If you do this in your
   home directory, this results in the folder `~/deltachat-android` which is just fine.
 
+# Generate JSON-RPC bindings
+
+To generate the JSON-RPC bindings (ex. `chat.delta.rpc.*` package)
+install the [dcrpcgen tool](https://github.com/chatmail/dcrpcgen)
+then generate the `schema.json` file:
+
+```
+# install deltachat-rpc-server program:
+cargo install --path ./jni/deltachat-core-rust/deltachat-rpc-server
+# check the version of core matches:
+deltachat-rpc-server --version
+# generate the schema:
+deltachat-rpc-server --openrpc > schema.json
+```
+
+then pass the schema file to the `dcrpcgen` tool to generate the
+code:
+
+```
+dcrpcgen java --schema schema.json -o ./src/main/java/
+```
+
 # Build Using Nix
 
 The repository contains [Nix](https://nixos.org/) development environment

build.gradle

@@ -173,7 +173,6 @@ dependencies {
     implementation 'com.google.zxing:core:3.3.0' // fixed version to support SDK<24
     implementation ('com.journeyapps:zxing-android-embedded:4.3.0') { transitive = false } // QR Code scanner
     implementation 'com.fasterxml.jackson.core:jackson-databind:2.11.1' // used as JSON library
-    implementation 'com.google.code.gson:gson:2.12.1' // used as JSON library.
     implementation 'com.github.Baseflow:PhotoView:2.3.0' // does the zooming on photos / media
     implementation 'com.github.penfeizhou.android.animation:awebp:3.0.5' // animated webp support.
     implementation 'com.caverock:androidsvg-aar:1.4' // SVG support.

jni/deltachat-core-rust

@@ -0,0 +1,124 @@
+/* Autogenerated file, do not edit manually */
+package chat.delta.rpc;
+
+import chat.delta.util.SettableFuture;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutionException;
+
+/* Basic RPC Transport implementation */ 
+public abstract class BaseTransport implements Rpc.Transport {
+  private final Map<Integer, SettableFuture<JsonNode>> requestFutures = new ConcurrentHashMap<>();
+  private int requestId = 0;
+  private final ObjectMapper mapper = new ObjectMapper();
+  private Thread worker;
+
+  /* Send a Request as raw JSON String to the RPC server */
+  protected abstract void sendRequest(String jsonRequest);
+
+  /* Get next Response as raw JSON String from the RPC server */
+  protected abstract String getResponse();
+
+  public ObjectMapper getObjectMapper() {
+    return mapper;
+  }
+
+  public void call(String method, JsonNode... params) throws RpcException {
+    innerCall(method, params);
+  }
+
+  public <T> T callForResult(TypeReference<T> resultType, String method, JsonNode... params) throws RpcException {
+    try {
+      JsonNode node = innerCall(method, params);
+      if (node.isNull()) return null;
+      return mapper.readValue(node.traverse(), resultType);
+    } catch (IOException e) {
+      throw new RpcException(e.getMessage());
+    }
+  }
+
+  private JsonNode innerCall(String method, JsonNode... params) throws RpcException {
+    int id;
+    synchronized (this) {
+      id = ++requestId;
+      ensureWorkerThread();
+    }
+    try {
+      String jsonRequest = mapper.writeValueAsString(new Request(method, params, id));
+      SettableFuture<JsonNode> future = new SettableFuture<>();
+      requestFutures.put(id, future);
+      sendRequest(jsonRequest);
+      return future.get();
+    } catch (ExecutionException e) {
+      throw (RpcException)e.getCause();
+    } catch (InterruptedException e) {
+      throw new RpcException(e.getMessage());
+    } catch (JsonProcessingException e) {
+      throw new RpcException(e.getMessage());
+    }
+  }
+
+  private void ensureWorkerThread() {
+    if (worker != null) return;
+
+    worker = new Thread(() -> {
+        while (true) {
+          try {
+            processResponse();
+          } catch (JsonProcessingException e) {
+            e.printStackTrace();
+          }
+        }
+    }, "jsonrpcThread");
+    worker.start();
+  }
+
+  private void processResponse() throws JsonProcessingException {
+    String jsonResponse = getResponse();
+    Response response = mapper.readValue(jsonResponse, Response.class);
+
+    if (response.id == 0) { // Got JSON-RPC notification/event, ignore
+      return;
+    }
+
+    SettableFuture<JsonNode> future = requestFutures.remove(response.id);
+    if (future == null) { // Got a response with unknown ID, ignore
+      return;
+    }
+
+    if (response.error != null) {
+      future.setException(new RpcException(response.error.toString()));
+    } else if (response.result != null) {
+      future.set(response.result);
+    } else {
+      future.setException(new RpcException("Got JSON-RPC response without result or error: " + jsonResponse));
+    }
+  }
+
+  private static class Request {
+    private final String jsonrpc = "2.0";
+    public final String method;
+    public final JsonNode[] params;
+    public final int id;
+
+    public Request(String method, JsonNode[] params, int id) {
+      this.method = method;
+      this.params = params;
+      this.id = id;
+    }
+  }
+
+  private static class Response {
+    public String jsonrpc;
+    public int id;
+    public JsonNode result;
+    public JsonNode error;
+  }
+}