tauri: refactor: fix some clippy warnings

Author: WofWca

packages/target-tauri/crates/user-notify/examples/test.rs

@@ -61,7 +61,7 @@ async fn main() -> anyhow::Result<()> {
     notification = notification
         .title("my title2")
         .body("my body2")
-        .set_thread_id(&format!("thread-id"));
+        .set_thread_id("thread-id");
 
     log::debug!("4");
     manager.send_notification(notification).await?;
@@ -73,7 +73,7 @@ async fn main() -> anyhow::Result<()> {
     let notification = user_notify::NotificationBuilder::new()
         .title("my title")
         .body("my body")
-        .set_thread_id(&format!("thread-id"))
+        .set_thread_id("thread-id")
         .set_user_info(info)
         .set_category_id("my.app.123.textinput");
 
@@ -90,8 +90,7 @@ async fn main() -> anyhow::Result<()> {
     assert!(
         active
             .iter()
-            .find(|handle| handle.get_user_info().contains_key("hey"))
-            .is_some()
+            .any(|handle| handle.get_user_info().contains_key("hey"))
     );
 
     let _ = ctrl_c().await;

packages/target-tauri/src-tauri/build.rs

@@ -114,20 +114,20 @@ fn get_git_ref() -> String {
     {
         git_branch = git_symbolic_ref
             .split('/')
-            .last()
+            .next_back()
             .unwrap_or("main")
             .to_string();
-        println!("{} {}", git_symbolic_ref, git_branch);
+        println!("{git_symbolic_ref} {git_branch}");
     } else {
         git_branch = gather_process_stdout("git", &["symbolic-ref", "HEAD"])
-            .map(|r| r.split('/').last().unwrap_or("main").to_owned())
+            .map(|r| r.split('/').next_back().unwrap_or("main").to_owned())
             .unwrap_or("main".to_owned())
             .to_string();
     }
 
     if git_branch == "main" {
         git_describe
     } else {
-        format!("{}-{}", git_describe, git_branch)
+        format!("{git_describe}-{git_branch}")
     }
 }

packages/target-tauri/src-tauri/src/blobs.rs

@@ -87,7 +87,7 @@ pub(crate) fn delta_blobs_protocol<R: tauri::Runtime>(
                 // trace!("file_path: {file_path:?}");
 
                 assert_eq!(
-                    file_path.components().last().unwrap().as_os_str(),
+                    file_path.components().next_back().unwrap().as_os_str(),
                     file_name
                 );
                 assert!(file_path

packages/target-tauri/src-tauri/src/html_window/email_scheme.rs

@@ -37,8 +37,7 @@ pub(crate) fn email_protocol<R: tauri::Runtime>(
     let webview_label = ctx.webview_label();
     if !webview_label.starts_with("html-window:") || !webview_label.ends_with("-mail") {
         error!(
-            "prevented other window from accessing email:// scheme (webview label: {})",
-            webview_label
+            "prevented other window from accessing email:// scheme (webview label: {webview_label})"
         );
         return;
     }

packages/target-tauri/src-tauri/src/lib.rs

@@ -78,7 +78,7 @@ const DEFAULT_WINDOW_HEIGHT: f64 = 600.;
 // Learn more about Tauri commands at https://tauri.app/develop/calling-rust/
 #[tauri::command]
 fn greet(name: &str) -> String {
-    format!("Hello, {}! You've been greeted from Rust!", name)
+    format!("Hello, {name}! You've been greeted from Rust!")
 }
 
 #[tauri::command]

packages/target-tauri/src-tauri/src/menus/mod.rs

@@ -53,7 +53,7 @@ pub(crate) fn handle_menu_event(app: &AppHandle, event: MenuEvent) {
     let app = app.clone();
     let future = spawn(async move {
         if let Err(e) = handle_event(&app, event).await {
-            log::error!("{:?}", e);
+            log::error!("{e:?}");
         }
     });
     drop(future);

packages/target-tauri/src-tauri/src/state/tray_manager.rs

@@ -42,22 +42,20 @@ impl TrayManager {
                     tray.set_visible(false)?;
                 }
             }
-        } else {
-            if currently_active != wanted_state {
-                if wanted_state {
-                    let tray = build_tray_icon(app)?;
-                    let previous = self.tray.write().await.replace(tray);
-                    assert!(previous.is_none());
-                    self.update_badge(app).await?;
+        } else if currently_active != wanted_state {
+            if wanted_state {
+                let tray = build_tray_icon(app)?;
+                let previous = self.tray.write().await.replace(tray);
+                assert!(previous.is_none());
+                self.update_badge(app).await?;
+            } else {
+                let previous = self.tray.write().await.take();
+                if let Some(tray) = previous {
+                    tray.set_visible(false)?;
+                    let tray_option = app.remove_tray_by_id(tray.id());
+                    drop(tray_option);
                 } else {
-                    let previous = self.tray.write().await.take();
-                    if let Some(tray) = previous {
-                        tray.set_visible(false)?;
-                        let tray_option = app.remove_tray_by_id(tray.id());
-                        drop(tray_option);
-                    } else {
-                        unreachable!()
-                    }
+                    unreachable!()
                 }
             }
         }

packages/target-tauri/src-tauri/src/state/webxdc_instances.rs

@@ -86,8 +86,8 @@ impl WebxdcInstancesState {
         self.inner
             .read()
             .await
-            .iter()
-            .map(|(window_label, _)| window_label.to_owned())
+            .keys()
+            .map(|window_label| window_label.to_owned())
             .collect()
     }
     pub(crate) async fn get_all_webxdc_windows_for_account_id(

packages/target-tauri/src-tauri/src/temp_file.rs

@@ -65,7 +65,7 @@ async fn create_tmp_file(app: &AppHandle, name: &str) -> Result<(File, PathBuf),
         .ok_or(Error::InvalidFileName)?;
     let file_path = dir.join(file_name);
 
-    assert!(file_path.components().last().unwrap().as_os_str() == file_name);
+    assert!(file_path.components().next_back().unwrap().as_os_str() == file_name);
     assert!(file_path
         .components()
         .rev()
@@ -109,7 +109,7 @@ async fn delete_tmp_file(app: &AppHandle, path: SafePathBuf) -> Result<(), Error
 // create tmp folder
 pub(crate) async fn create_tmp_folder(app: &AppHandle) -> Result<(), Error> {
     let tmp_folder = get_temp_folder_path(app)?;
-    info!("using temp folder at {:?}", tmp_folder);
+    info!("using temp folder at {tmp_folder:?}");
     create_dir_all(get_temp_folder_path(app)?).await?;
     Ok(())
 }
@@ -119,7 +119,7 @@ pub(crate) async fn create_tmp_folder(app: &AppHandle) -> Result<(), Error> {
 pub(crate) async fn clear_tmp_folder(app: &AppHandle) -> Result<(), Error> {
     let tmp_folder = get_temp_folder_path(app)?;
     if !exists(&tmp_folder)? {
-        warn!("tmp folder does not exist at: {:?}", tmp_folder);
+        warn!("tmp folder does not exist at: {tmp_folder:?}");
         return Ok(());
     }
 

packages/target-tauri/src-tauri/src/themes/themes.rs

@@ -83,7 +83,7 @@ impl ThemeMetadata {
             ) {
                 map.insert(key, value);
             } else {
-                log::warn!("can't parse css variable {:?}", captures);
+                log::warn!("can't parse css variable {captures:?}");
                 continue;
             }
         }