Skip to content

Commit 7e4f064

Browse files
CopilotMalcolmnixon
andcommitted
Fix MSTest assertion code smells using HasCount and IsEmpty
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
1 parent 1491f63 commit 7e4f064

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/DemaConsulting.BuildMark.Tests/GitHubGraphQLClientTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_Valid
6161

6262
// Assert
6363
Assert.IsNotNull(issueIds);
64-
Assert.AreEqual(3, issueIds.Count);
64+
Assert.HasCount(3, issueIds);
6565
Assert.AreEqual(123, issueIds[0]);
6666
Assert.AreEqual(456, issueIds[1]);
6767
Assert.AreEqual(789, issueIds[2]);
@@ -94,7 +94,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_NoIss
9494

9595
// Assert
9696
Assert.IsNotNull(issueIds);
97-
Assert.AreEqual(0, issueIds.Count);
97+
Assert.IsEmpty(issueIds);
9898
}
9999

100100
/// <summary>
@@ -118,7 +118,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_Missi
118118

119119
// Assert
120120
Assert.IsNotNull(issueIds);
121-
Assert.AreEqual(0, issueIds.Count);
121+
Assert.IsEmpty(issueIds);
122122
}
123123

124124
/// <summary>
@@ -138,7 +138,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_HttpE
138138

139139
// Assert
140140
Assert.IsNotNull(issueIds);
141-
Assert.AreEqual(0, issueIds.Count);
141+
Assert.IsEmpty(issueIds);
142142
}
143143

144144
/// <summary>
@@ -158,7 +158,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_Inval
158158

159159
// Assert
160160
Assert.IsNotNull(issueIds);
161-
Assert.AreEqual(0, issueIds.Count);
161+
Assert.IsEmpty(issueIds);
162162
}
163163

164164
/// <summary>
@@ -190,7 +190,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_Singl
190190

191191
// Assert
192192
Assert.IsNotNull(issueIds);
193-
Assert.AreEqual(1, issueIds.Count);
193+
Assert.HasCount(1, issueIds);
194194
Assert.AreEqual(999, issueIds[0]);
195195
}
196196

@@ -225,7 +225,7 @@ public async Task GitHubGraphQLClient_FindIssueIdsLinkedToPullRequestAsync_Missi
225225

226226
// Assert
227227
Assert.IsNotNull(issueIds);
228-
Assert.AreEqual(2, issueIds.Count);
228+
Assert.HasCount(2, issueIds);
229229
Assert.AreEqual(100, issueIds[0]);
230230
Assert.AreEqual(200, issueIds[1]);
231231
}

0 commit comments

Comments
 (0)