Add Index property to ItemInfo for ordering changes by PR number

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Author: Copilot

src/DemaConsulting.BuildMark/BuildInformation.cs

@@ -197,6 +197,11 @@ public static async Task<BuildInformation> CreateAsync(IRepoConnector connector,
             }
         }
 
+        // Sort all lists by Index to ensure chronological order
+        nonBugChanges.Sort((a, b) => a.Index.CompareTo(b.Index));
+        bugs.Sort((a, b) => a.Index.CompareTo(b.Index));
+        knownIssues.Sort((a, b) => a.Index.CompareTo(b.Index));
+
         // Create and return build information with all collected data
         return new BuildInformation(
             fromTagInfo,

src/DemaConsulting.BuildMark/ItemInfo.cs

@@ -27,4 +27,5 @@ namespace DemaConsulting.BuildMark;
 /// <param name="Title">Item title.</param>
 /// <param name="Url">Item URL.</param>
 /// <param name="Type">Item type (bug, feature, etc.).</param>
-public record ItemInfo(string Id, string Title, string Url, string Type);
+/// <param name="Index">Numeric index for sorting (PR number for PRs, issue number for issues).</param>
+public record ItemInfo(string Id, string Title, string Url, string Type, int Index = 0);

src/DemaConsulting.BuildMark/RepoConnectors/GitHubRepoConnector.cs

@@ -238,15 +238,15 @@ public override async Task<List<ItemInfo>> GetChangesBetweenTagsAsync(Version? f
                         }
                     }
 
-                    issueDetailsMap[issueNumber] = new ItemInfo(issueNumber, issueTitle, issueUrl, issueType);
+                    issueDetailsMap[issueNumber] = new ItemInfo(issueNumber, issueTitle, issueUrl, issueType, int.Parse(issueNumber));
                 }
             }
             catch (Exception)
             {
                 // If we can't fetch issue list, create fallback entries
                 foreach (var issueNumber in issueNumbers)
                 {
-                    issueDetailsMap[issueNumber] = new ItemInfo(issueNumber, $"Issue #{issueNumber}", string.Empty, "other");
+                    issueDetailsMap[issueNumber] = new ItemInfo(issueNumber, $"Issue #{issueNumber}", string.Empty, "other", int.Parse(issueNumber));
                 }
             }
         }
@@ -301,7 +301,12 @@ public override async Task<List<ItemInfo>> GetChangesBetweenTagsAsync(Version? f
                     }
                 }
 
-                changes.Add(new ItemInfo($"#{prNumber}", prTitle, prUrl, prType));
+                changes.Add(new ItemInfo(
+                    $"#{prNumber}",
+                    prTitle,
+                    prUrl,
+                    prType,
+                    int.Parse(prNumber)));
             }
         }
 
@@ -404,7 +409,7 @@ public override async Task<List<ItemInfo>> GetOpenIssuesAsync()
                     }
                 }
 
-                openIssues.Add(new ItemInfo(issueNumber, issueTitle, issueUrl, issueType));
+                openIssues.Add(new ItemInfo(issueNumber, issueTitle, issueUrl, issueType, int.Parse(issueNumber)));
             }
             catch (System.Text.Json.JsonException)
             {

src/DemaConsulting.BuildMark/RepoConnectors/MockRepoConnector.cs

@@ -119,12 +119,13 @@ public Task<List<ItemInfo>> GetChangesBetweenTagsAsync(Version? from, Version? t
             if (issues.Count > 0)
             {
                 // PR has associated issues - add them as changes
+                // Use PR number as index for chronological ordering
                 foreach (var issueId in issues)
                 {
                     var title = _issueTitles.TryGetValue(issueId, out var issueTitle) ? issueTitle : $"Issue {issueId}";
                     var url = $"https://github.com/example/repo/issues/{issueId}";
                     var type = _issueTypes.TryGetValue(issueId, out var issueType) ? issueType : "other";
-                    changes.Add(new ItemInfo(issueId, title, url, type));
+                    changes.Add(new ItemInfo(issueId, title, url, type, int.Parse(pr)));
                 }
             }
             else
@@ -134,7 +135,8 @@ public Task<List<ItemInfo>> GetChangesBetweenTagsAsync(Version? from, Version? t
                     $"#{pr}",
                     $"PR #{pr}",
                     $"https://github.com/example/repo/pull/{pr}",
-                    "other"));
+                    "other",
+                    int.Parse(pr)));
             }
         }
 
@@ -173,7 +175,8 @@ public Task<List<ItemInfo>> GetOpenIssuesAsync()
                 issueId,
                 _issueTitles.TryGetValue(issueId, out var title) ? title : $"Issue {issueId}",
                 $"https://github.com/example/repo/issues/{issueId}",
-                _issueTypes.TryGetValue(issueId, out var type) ? type : "other"))
+                _issueTypes.TryGetValue(issueId, out var type) ? type : "other",
+                int.Parse(issueId)))
             .ToList();
         return Task.FromResult(openIssuesData);
     }

test/DemaConsulting.BuildMark.Tests/BuildInformationTests.cs

@@ -155,6 +155,32 @@ public async Task BuildInformation_CreateAsync_CollectsIssuesCorrectly()
         Assert.AreEqual("5", buildInfo.KnownIssues[1].Id);
     }
 
+    /// <summary>
+    ///     Test that CreateAsync orders changes by Index (PR number).
+    /// </summary>
+    [TestMethod]
+    public async Task BuildInformation_CreateAsync_OrdersChangesChronologically()
+    {
+        // Create build information for version with issues
+        var connector = new MockRepoConnector();
+        var buildInfo = await BuildInformation.CreateAsync(connector, Version.Create("ver-1.1.0"));
+
+        // Verify changes are ordered by Index (PR number)
+        // Issue #1 from PR #10 should come before PR #13
+        Assert.HasCount(2, buildInfo.Changes);
+        Assert.AreEqual("1", buildInfo.Changes[0].Id);
+        Assert.AreEqual(10, buildInfo.Changes[0].Index);
+        Assert.AreEqual("#13", buildInfo.Changes[1].Id);
+        Assert.AreEqual(13, buildInfo.Changes[1].Index);
+        
+        // Verify Index values are in ascending order
+        for (var i = 0; i < buildInfo.Changes.Count - 1; i++)
+        {
+            Assert.IsLessThanOrEqualTo(buildInfo.Changes[i + 1].Index, buildInfo.Changes[i].Index, 
+                $"Changes should be ordered by Index. Found {buildInfo.Changes[i].Index} before {buildInfo.Changes[i + 1].Index}");
+        }
+    }
+
     /// <summary>
     ///     Test that CreateAsync separates bug and change issues.
     /// </summary>