Skip to content

Commit a07aa52

Browse files
CopilotMalcolmnixon
andcommitted
Add --state all to gh pr list to include closed PRs
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
1 parent 3d87dac commit a07aa52

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/DemaConsulting.BuildMark/RepoConnectors/GitHubRepoConnector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ public override async Task<List<string>> GetPullRequestsBetweenTagsAsync(Version
180180
try
181181
{
182182
// Search for PRs containing this commit using GitHub CLI
183-
var prSearchOutput = await RunCommandAsync("gh", $"pr list --search {commitHash} --json number --jq .[].number");
183+
var prSearchOutput = await RunCommandAsync("gh", $"pr list --state all --search {commitHash} --json number --jq .[].number");
184184
var prNumbers = prSearchOutput
185185
.Split('\n', StringSplitOptions.RemoveEmptyEntries)
186186
.Select(n => n.Trim())

test/DemaConsulting.BuildMark.Tests/GitHubRepoConnectorTests.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_ReturnsExp
142142
// Mock GitHub CLI to search for PRs by commit hash
143143
connector.AddCommandResult(
144144
"gh",
145-
"pr list --search abc123def456 --json number --jq .[].number",
145+
"pr list --state all --search abc123def456 --json number --jq .[].number",
146146
"10");
147147

148148
connector.AddCommandResult(
149149
"gh",
150-
"pr list --search def456789abc --json number --jq .[].number",
150+
"pr list --state all --search def456789abc --json number --jq .[].number",
151151
"11");
152152

153153
// Act
@@ -182,7 +182,7 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_HandlesNul
182182
// Mock GitHub CLI to search for PRs by commit hash
183183
connector.AddCommandResult(
184184
"gh",
185-
"pr list --search abc123def456 --json number --jq .[].number",
185+
"pr list --state all --search abc123def456 --json number --jq .[].number",
186186
"10");
187187

188188
// Act
@@ -211,7 +211,7 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_HandlesNul
211211
// Mock GitHub CLI to search for PRs by commit hash
212212
connector.AddCommandResult(
213213
"gh",
214-
"pr list --search abc123def456 --json number --jq .[].number",
214+
"pr list --state all --search abc123def456 --json number --jq .[].number",
215215
"11");
216216

217217
// Act
@@ -240,7 +240,7 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_HandlesBot
240240
// Mock GitHub CLI to search for PRs by commit hash
241241
connector.AddCommandResult(
242242
"gh",
243-
"pr list --search abc123def456 --json number --jq .[].number",
243+
"pr list --state all --search abc123def456 --json number --jq .[].number",
244244
"12");
245245

246246
// Act
@@ -272,7 +272,7 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_UsesHeadWh
272272
// Mock GitHub CLI to search for PRs by commit hash
273273
connector.AddCommandResult(
274274
"gh",
275-
"pr list --search abc123def456 --json number --jq .[].number",
275+
"pr list --state all --search abc123def456 --json number --jq .[].number",
276276
"15");
277277

278278
// Act - using a version that doesn't exist as a tag
@@ -303,17 +303,17 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_UsesGitHub
303303
// Mock GitHub CLI to search for PRs by commit hash
304304
connector.AddCommandResult(
305305
"gh",
306-
"pr list --search abc123def456 --json number --jq .[].number",
306+
"pr list --state all --search abc123def456 --json number --jq .[].number",
307307
"18");
308308

309309
connector.AddCommandResult(
310310
"gh",
311-
"pr list --search def456789abc --json number --jq .[].number",
311+
"pr list --state all --search def456789abc --json number --jq .[].number",
312312
"19");
313313

314314
connector.AddCommandResult(
315315
"gh",
316-
"pr list --search 789abcdef123 --json number --jq .[].number",
316+
"pr list --state all --search 789abcdef123 --json number --jq .[].number",
317317
"20");
318318

319319
// Act
@@ -344,12 +344,12 @@ public async Task GitHubRepoConnector_GetPullRequestsBetweenTagsAsync_Deduplicat
344344
// Mock GitHub CLI to search for PRs by commit hash - both commits are from PR 20
345345
connector.AddCommandResult(
346346
"gh",
347-
"pr list --search 5e541195f387259ee8d72d33b70579a0f7b6fde4 --json number --jq .[].number",
347+
"pr list --state all --search 5e541195f387259ee8d72d33b70579a0f7b6fde4 --json number --jq .[].number",
348348
"20");
349349

350350
connector.AddCommandResult(
351351
"gh",
352-
"pr list --search c3eb81cd24b9d054a626a9785b16975f0808ecb2 --json number --jq .[].number",
352+
"pr list --state all --search c3eb81cd24b9d054a626a9785b16975f0808ecb2 --json number --jq .[].number",
353353
"20");
354354

355355
// Act

0 commit comments

Comments
 (0)