Skip to content

Commit ba5a8bb

Browse files
CopilotMalcolmnixon
andcommitted
Use Newtonsoft.Json for Release deserialization and fix formatting
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
1 parent 4ae2fb2 commit ba5a8bb

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/DemaConsulting.BuildMark/DemaConsulting.BuildMark.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
<PrivateAssets>all</PrivateAssets>
5757
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
5858
</PackageReference>
59+
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
5960
<PackageReference Include="Octokit" Version="14.0.0" />
6061
<PackageReference Include="SonarAnalyzer.CSharp" Version="10.19.0.132793">
6162
<PrivateAssets>all</PrivateAssets>

src/DemaConsulting.BuildMark/RepoConnectors/GitHubRepoConnector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ private static async Task<IReadOnlyList<Release>> GetAllReleasesAsync(
592592
return releaseTagNames.Select(tagName =>
593593
{
594594
var json = $$"""{"tag_name":"{{tagName}}"}""";
595-
return System.Text.Json.JsonSerializer.Deserialize<Release>(json) ?? throw new InvalidOperationException($"Failed to create Release object for tag {tagName}");
595+
return Newtonsoft.Json.JsonConvert.DeserializeObject<Release>(json) ?? throw new InvalidOperationException($"Failed to create Release object for tag {tagName}");
596596
}).ToList();
597597
}
598598

test/DemaConsulting.BuildMark.Tests/RepoConnectors/GitHub/GitHubGraphQLClientTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ protected override async Task<HttpResponseMessage> SendAsync(
353353
var requestBody = request.Content != null
354354
? await request.Content.ReadAsStringAsync(cancellationToken)
355355
: string.Empty;
356-
356+
357357
string responseContent;
358358
if (_requestCount == 0 || !requestBody.Contains("\"after\""))
359359
{
@@ -704,7 +704,7 @@ protected override async Task<HttpResponseMessage> SendAsync(
704704
var requestBody = request.Content != null
705705
? await request.Content.ReadAsStringAsync(cancellationToken)
706706
: string.Empty;
707-
707+
708708
string responseContent;
709709
if (_requestCount == 0 || !requestBody.Contains("\"after\""))
710710
{
@@ -1045,7 +1045,7 @@ protected override async Task<HttpResponseMessage> SendAsync(
10451045
var requestBody = request.Content != null
10461046
? await request.Content.ReadAsStringAsync(cancellationToken)
10471047
: string.Empty;
1048-
1048+
10491049
string responseContent;
10501050
if (_requestCount == 0 || !requestBody.Contains("\"after\""))
10511051
{

0 commit comments

Comments
 (0)