Add SonarAnalyzer.CSharp dependency and fix S3267 issue

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Author: Copilot

src/DemaConsulting.SpdxModel/DemaConsulting.SpdxModel.csproj

@@ -36,6 +36,10 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="10.16.1.129956">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>

src/DemaConsulting.SpdxModel/SpdxCreationInformation.cs

@@ -124,11 +124,13 @@ public void Validate(List<string> issues)
             issues.Add("Document Invalid Creator Field - Empty");
 
         // Validate Creators Field Entries
-        foreach (var creator in Creators)
-            if (!creator.StartsWith("Person:") &&
-                !creator.StartsWith("Organization:") &&
-                !creator.StartsWith("Tool:"))
-                issues.Add($"Document Invalid Creator Entry '{creator}'");
+        foreach (var creator in Creators.Where(c =>
+            !c.StartsWith("Person:") &&
+            !c.StartsWith("Organization:") &&
+            !c.StartsWith("Tool:")))
+        {
+            issues.Add($"Document Invalid Creator Entry '{creator}'");
+        }
 
         // Validate Created Field
         if (!SpdxHelpers.IsValidSpdxDateTime(Created))

test/DemaConsulting.SpdxModel.Tests/DemaConsulting.SpdxModel.Tests.csproj

@@ -35,6 +35,10 @@
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="10.16.1.129956">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
 	</ItemGroup>
 
 	<ItemGroup>