Merge pull request #3444 from demergent-labs/chunk_unstable

Chunk unstable

Author: lastmjs

.github/actions/get_exclude_dirs/action.yml

@@ -30,6 +30,8 @@ runs:
               ') }}"
 
               UNSTABLE_EXCLUSIONS="${{ format('
+              examples/stable/test/property/ic_api/chunk
+              examples/stable/test/property/candid_rpc/canister_methods/inspect_message
               ') }}"
 
               # These tests are unstable because of problems in external code. Consequently, failing tests are not helpful, so we're disabling them entirely for the time being.

.github/copilot-instructions.md

@@ -91,6 +91,20 @@ Remember, before the PR can be considered complete, you must at least do the fol
 - Use console.info if you intend for your logs to be committed to the codebase. Use console.log only for debugging purposes.
 - Use numeric separators for large numbers, for example 1_000_000 instead of 1000000
 
+## Code Review Guidelines
+
+The following guidelines should be followed whenever performing a code review.
+
+1. Enumerate and comment with a summary of all new features added. A feature is generally something that the end-user developer using Azle would be exposed to. For example, if we materially change the interface of, add to, or change the behavior of any of the APIs exported from the top-level `azle` npm package. If no new features were added, please say so.
+2. Enumerate and comment with a summary of all new breaking changes introduced. If no new breaking changes were introduced, please say so.
+3. Perform the following code quality checks
+    1. Declarative
+    2. Appropriate JSDocs, Rustdocs, or comments. We JSDocs and Rustdocs on all new functions and types. We only want code comments if an average competent software developer would not have enough information to understand the code just be reading the code.
+    3. Beautiful error handling (no unwraps, no expects, proper try/catch, all error conditions handled, etc)
+    4. Thoroughly tested (either the current tests are sufficient or new tests have been added)
+4. Ensure that the implementation is free of bugs, typos, organizational problems, code smells, etc
+5. In your review comment, please create a checkbox list for this entire numbered list (just copy the list entirely but replace the numbers with checkboxes) and check off each task that you have completed.
+
 ## Human Notes
 
 This section is for humans only, please ignore it if you are an AI.

.github/pull_request_template.md

@@ -20,22 +20,22 @@
 
 ## Reviewer
 
-- [ ] Related issues have been linked and all tasks have been completed or made into separate issues
-- [ ] All features are described below in the "Features" section
-- [ ] All breaking changes
-    - [ ] Described below in the "Breaking Changes" section
-    - [ ] Migration path described
-- [ ] PR title:
-    - [ ] `feat:` prefix used if functionality should be included in the `Features` section of the release notes
-    - [ ] Indicates breaking changes with suffix "(breaking changes)"
-    - [ ] Described well for release notes
-    - [ ] Not sentence cased
-- [ ] Code quality
-    - [ ] Declarative
-    - [ ] Appropriate JSDocs, Rustdocs, or comments
-    - [ ] Beautiful error handling (no unwraps, expects, etc)
-    - [ ] Thoroughly tested
-- [ ] New documentation enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053)
+- [x] Related issues have been linked and all tasks have been completed or made into separate issues
+- [x] All features are described below in the "Features" section
+- [x] All breaking changes
+    - [x] Described below in the "Breaking Changes" section
+    - [x] Migration path described
+- [x] PR title:
+    - [x] `feat:` prefix used if functionality should be included in the `Features` section of the release notes
+    - [x] Indicates breaking changes with suffix "(breaking changes)"
+    - [x] Described well for release notes
+    - [x] Not sentence cased
+- [x] Code quality
+    - [x] Declarative
+    - [x] Appropriate JSDocs, Rustdocs, or comments
+    - [x] Beautiful error handling (no unwraps, expects, etc)
+    - [x] Thoroughly tested
+- [x] New documentation enumerated in [the release issue](https://github.com/demergent-labs/azle/issues/2053)
 
 ## Features
 

package.json

@@ -91,7 +91,7 @@
             "node": "22.18.0",
             "rust": "1.89.0",
             "cargo-auditable": "0.7.0",
-            "cargo-audit": "https://github.com/rustsec/rustsec?rev=13604e1909456e25752784681f0367b13a21e47b#13604e19",
+            "cargo-audit": "https://github.com/rustsec/rustsec?rev=4cc355b042cc2c7468642c022191d8f1f1352884#4cc355b0",
             "cargo-bundle-licenses": "4.0.0",
             "cargo-deny": "0.18.4",
             "wasi2ic": "0.2.15"