Skip to content

Code Review Feedback #4

@over-geek

Description

@over-geek

Great work on this project 😍! Kindly take a look at the following comments😁

  • Great work with your date functionality 😎, however if you want other ways of implementing it, you can check out the toLocaleDateString method of the date class.
  • I would like you to consider deleting the a tags in the nav-item's because they are unnecessary for this page.
  • Kindly consider removing the default date in the date-container div since you are generating it dynamically with JavaScript.
  • Additionally, you should put the h1 tag before any other hx tag that you have on your file, in order to follow the HTML semantics.
  • Your approach to removing the class in the books div's with JavaScript looks great, but you could do the same with CSS and the nth:child(odd). This will select only the odd child in the class.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions