Improve how failures are handled by the directory_files_read function

[fhightower]

What?

Currently, if the directory_files_read function is unable to read one file in a directory, it raises an exception and does so in a way that is difficult to handle.

For example, let's say there are four files in a directory and the directory_files_read reads the first two correctly but fails with a UnicodeDecodeError on the third:

for path, contents in directory_files_read(directory_path, recursive=False):
    ...

There is no good way I'm aware of to handle this failure in a way that would let you skip the error and move on.

How?

I believe the best solution is to add error handling into this function.

[fhightower]

The challenge is that I'm unable to replicate the original issue. Will probably use mocking to patch the file_read call to raise an exception to test this.