205 overload resolution (#252)

* Missed this in net8 additions

* Fix overload resolution issues in Core

* Fix overload resolution issues in Tasks/Hopac

* Fix overload resolution issues in CancellableTaskResult

* WIP: TaskValidtionCE

* Wip merge sources

* Fix MergeSources for CTValidation

* cleanup

* Ensure IAsyncDisposable tests

* ignore nuget stuff

Author: TheAngryByrd

.github/workflows/build.yml

@@ -8,6 +8,7 @@ on:
   pull_request:
     branches:
       - master
+  workflow_dispatch:
 
 jobs:
 

Directory.Build.props

@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <DisableCheckingDuplicateNuGetItems>true</DisableCheckingDuplicateNuGetItems>
-    <NoWarn>$(NoWarn);FS2003; NU1903</NoWarn>
+    <NoWarn>$(NoWarn);FS2003; NU1903; NU1904</NoWarn>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningsAsErrors />
   </PropertyGroup>

src/FsToolkit.ErrorHandling.IcedTasks/CancellableTaskResultBuilderBase.fs

@@ -2,17 +2,17 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <OutputType>Library</OutputType>
-        <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
+        <TargetFrameworks>net6.0;netstandard2.0;netstandard2.1</TargetFrameworks>
         <LangVersion>preview</LangVersion>
         <DebugType>portable</DebugType>
         <NoWarn>FS3511;FS3513</NoWarn>
     </PropertyGroup>
     <ItemGroup>
+        <Compile Include="CancellableTaskResultBuilderBase.fs" />
         <Compile Include="CancellableTaskResultCE.fs" />
         <None Include="paket.references" />
         <Compile Include="CancellableTaskValidationCE.fs" />
         <Compile Include="CancellableTaskValidationOp.fs" />
-        <Watch Include="@(None)" />
     </ItemGroup>
     <ItemGroup>
         <ProjectReference

src/FsToolkit.ErrorHandling.IcedTasks/CancellableTaskResultCE.fs

@@ -118,19 +118,6 @@ module JobOptionCE =
         /// </summary>
         member inline _.Source(job: Job<_ option>) : Job<_ option> = job
 
-        /// <summary>
-        /// Method lets us transform data types into our internal representation.
-        /// </summary>
-        member inline _.Source(async: Async<_ option>) : Job<_ option> =
-            async
-            |> Job.fromAsync
-
-        /// <summary>
-        /// Method lets us transform data types into our internal representation.
-        /// </summary>
-        member inline _.Source(task: Task<_ option>) : Job<_ option> =
-            task
-            |> Job.awaitTask
 
     let jobOption = JobOptionBuilder()
 
@@ -173,3 +160,24 @@ module JobOptionCEExtensions =
             a
             |> Job.awaitTask
             |> Job.map Some
+
+[<AutoOpen>]
+// Having members as extensions gives them lower priority in
+// overload resolution and allows skipping more type annotations.
+module JobOptionCEExtensions2 =
+
+    type JobOptionBuilder with
+
+        /// <summary>
+        /// Method lets us transform data types into our internal representation.
+        /// </summary>
+        member inline _.Source(async: Async<_ option>) : Job<_ option> =
+            async
+            |> Job.fromAsync
+
+        /// <summary>
+        /// Method lets us transform data types into our internal representation.
+        /// </summary>
+        member inline _.Source(task: Task<_ option>) : Job<_ option> =
+            task
+            |> Job.awaitTask

src/FsToolkit.ErrorHandling.IcedTasks/CancellableTaskValidationCE.fs

@@ -123,20 +123,6 @@ module JobResultCE =
         /// </summary>
         member inline _.Source(job': Job<Result<_, _>>) : Job<Result<_, _>> = job'
 
-        /// <summary>
-        /// Method lets us transform data types into our internal representation. This is the identity method to recognize the self type.
-        /// </summary>
-        member inline _.Source(task: Task<Result<_, _>>) : Job<Result<_, _>> =
-            task
-            |> Job.awaitTask
-
-        /// <summary>
-        /// Method lets us transform data types into our internal representation.
-        /// </summary>
-        member inline _.Source(result: Async<Result<_, _>>) : Job<Result<_, _>> =
-            result
-            |> Job.fromAsync
-
     let jobResult = JobResultBuilder()
 
 [<AutoOpen>]
@@ -194,3 +180,22 @@ module JobResultCEExtensions =
             t
             |> Job.awaitUnitTask
             |> Job.map Ok
+
+
+[<AutoOpen>]
+module JobResultCEExtensions2 =
+    type JobResultBuilder with
+
+        /// <summary>
+        /// Method lets us transform data types into our internal representation. This is the identity method to recognize the self type.
+        /// </summary>
+        member inline _.Source(task: Task<Result<_, _>>) : Job<Result<_, _>> =
+            task
+            |> Job.awaitTask
+
+        /// <summary>
+        /// Method lets us transform data types into our internal representation.
+        /// </summary>
+        member inline _.Source(result: Async<Result<_, _>>) : Job<Result<_, _>> =
+            result
+            |> Job.fromAsync

src/FsToolkit.ErrorHandling.IcedTasks/FsToolkit.ErrorHandling.IcedTasks.fsproj

@@ -212,16 +212,8 @@ type TaskOptionBuilderBase() =
             )
         )
 
-    member inline this.Source(computation: Async<'T option>) : TaskOption<'T> =
-        computation
-        |> Async.StartImmediateAsTask
-
     member inline this.Source(taskOption: TaskOption<'T>) : TaskOption<'T> = taskOption
 
-    member inline this.Source(taskOption: ValueTask<'T option>) : TaskOption<'T> =
-        taskOption.AsTask()
-
-
 type TaskOptionBuilder() =
 
     inherit TaskOptionBuilderBase()
@@ -617,3 +609,17 @@ module TaskOptionCEExtensionsMediumPriority =
             computation
             |> Async.map Some
             |> Async.StartImmediateAsTask
+
+
+[<AutoOpen>]
+module TaskOptionCEExtensionsHighPriority2 =
+
+    // Medium priority extensions
+    type TaskOptionBuilderBase with
+
+        member inline this.Source(computation: Async<'T option>) : TaskOption<'T> =
+            computation
+            |> Async.StartImmediateAsTask
+
+        member inline this.Source(taskOption: ValueTask<'T option>) : TaskOption<'T> =
+            taskOption.AsTask()

src/FsToolkit.ErrorHandling.JobResult/JobOptionCE.fs

@@ -218,19 +218,6 @@ type TaskResultBuilderBase() =
     member inline this.Source(taskResult: TaskResult<'T, 'Error>) : TaskResult<'T, 'Error> =
         taskResult
 
-    member inline _.Source(result: Async<Result<_, _>>) : Task<Result<_, _>> =
-        result
-        |> Async.StartImmediateAsTask
-
-    member inline _.Source(t: ValueTask<Result<_, _>>) : Task<Result<_, _>> = task { return! t }
-
-    member inline _.Source(result: Result<_, _>) : Task<Result<_, _>> = Task.singleton result
-
-    member inline _.Source(result: Choice<_, _>) : Task<Result<_, _>> =
-        result
-        |> Result.ofChoice
-        |> Task.singleton
-
 
 type TaskResultBuilder() =
 
@@ -591,3 +578,23 @@ module TaskResultCEExtensionsMediumPriority =
             computation
             |> Async.map Ok
             |> Async.StartImmediateAsTask
+
+[<AutoOpen>]
+module TaskResultCEExtensionsHighPriority2 =
+
+    // Medium priority extensions
+    type TaskResultBuilderBase with
+
+
+        member inline _.Source(result: Async<Result<_, _>>) : Task<Result<_, _>> =
+            result
+            |> Async.StartImmediateAsTask
+
+        member inline _.Source(t: ValueTask<Result<_, _>>) : Task<Result<_, _>> = task { return! t }
+
+        member inline _.Source(result: Result<_, _>) : Task<Result<_, _>> = Task.singleton result
+
+        member inline _.Source(result: Choice<_, _>) : Task<Result<_, _>> =
+            result
+            |> Result.ofChoice
+            |> Task.singleton