Refactors orElse/orElseWith to not use CE

Author: TheAngryByrd

src/FsToolkit.ErrorHandling.JobResult/JobResult.fs

@@ -77,11 +77,8 @@ module JobResult =
   /// The result if the result is Ok, else returns <paramref name="ifError"/>.
   /// </returns>  
   let inline orElse (ifError : Job<Result<'ok,'error2>>) (result : Job<Result<'ok,'error>>)  = 
-    job {
-      match! result with
-      | Ok r -> return Ok r
-      | Error _ -> return! ifError
-    }
+    result
+    |> Job.bind(Result.either ok (fun _ -> ifError))
 
   /// <summary>
   /// Returns <paramref name="result"/> if it is <c>Ok</c>, otherwise executes <paramref name="ifErrorFunc"/> and returns the result.
@@ -103,11 +100,8 @@ module JobResult =
   /// The result if the result is Ok, else the result of executing <paramref name="ifErrorFunc"/>.
   /// </returns>
   let inline orElseWith (ifErrorFunc : 'error -> Job<Result<'ok,'error2>>) (result : Job<Result<'ok,'error>>) =
-    job {
-      match! result with
-      | Ok r -> return Ok r
-      | Error e -> return! ifErrorFunc e
-    }
+    result
+    |> Job.bind(Result.either ok ifErrorFunc)
 
   /// Replaces the wrapped value with unit
   let ignore jr =

src/FsToolkit.ErrorHandling.TaskResult/TaskResult.fs

@@ -71,11 +71,8 @@ module TaskResult =
   /// The result if the result is Ok, else returns <paramref name="ifError"/>.
   /// </returns>  
   let inline orElse (ifError : Task<Result<'ok,'error2>>) (result : Task<Result<'ok,'error>>)  = 
-    task {
-      match! result with
-      | Ok r -> return Ok r
-      | Error _ -> return! ifError
-    }
+    result
+    |> Task.bind(Result.either ok (fun _ -> ifError))
 
   /// <summary>
   /// Returns <paramref name="result"/> if it is <c>Ok</c>, otherwise executes <paramref name="ifErrorFunc"/> and returns the result.
@@ -97,11 +94,8 @@ module TaskResult =
   /// The result if the result is Ok, else the result of executing <paramref name="ifErrorFunc"/>.
   /// </returns>
   let inline orElseWith (ifErrorFunc : 'error -> Task<Result<'ok,'error2>>) (result : Task<Result<'ok,'error>>) =
-    task {
-      match! result with
-      | Ok r -> return Ok r
-      | Error e -> return! ifErrorFunc e
-    }
+    result
+    |> Task.bind(Result.either ok ifErrorFunc)
 
   /// Replaces the wrapped value with unit
   let ignore tr =

src/FsToolkit.ErrorHandling/AsyncResult.fs

@@ -80,11 +80,8 @@ module AsyncResult =
   /// The result if the result is Ok, else returns <paramref name="ifError"/>.
   /// </returns>  
   let inline orElse (ifError : Async<Result<'ok,'error2>>) (result : Async<Result<'ok,'error>>)  = 
-    async {
-      match! result with
-      | Ok r -> return Ok r
-      | Error _ -> return! ifError
-    }
+    result
+    |> Async.bind(Result.either ok (fun _ -> ifError))
 
   /// <summary>
   /// Returns <paramref name="result"/> if it is <c>Ok</c>, otherwise executes <paramref name="ifErrorFunc"/> and returns the result.
@@ -106,11 +103,8 @@ module AsyncResult =
   /// The result if the result is Ok, else the result of executing <paramref name="ifErrorFunc"/>.
   /// </returns>
   let inline orElseWith (ifErrorFunc : 'error -> Async<Result<'ok,'error2>>) (result : Async<Result<'ok,'error>>) =
-    async {
-      match! result with
-      | Ok r -> return Ok r
-      | Error e -> return! ifErrorFunc e
-    }
+    result
+    |> Async.bind(Result.either ok ifErrorFunc)
 
   /// Replaces the wrapped value with unit
   let ignore ar =

src/FsToolkit.ErrorHandling/Result.fs

@@ -65,9 +65,7 @@ module Result =
   /// The result if the result is Ok, else returns <paramref name="ifError"/>.
   /// </returns>  
   let inline orElse (ifError : Result<'ok,'error2>) (result : Result<'ok,'error>)  = 
-    match result with
-    | Ok r -> Ok r
-    | Error _ -> ifError
+    result |> either Ok (fun _ -> ifError)
 
 
   /// <summary>
@@ -90,9 +88,7 @@ module Result =
   /// The result if the result is Ok, else the result of executing <paramref name="ifErrorFunc"/>.
   /// </returns>
   let inline orElseWith (ifErrorFunc : 'error -> Result<'ok,'error2>) (result : Result<'ok,'error>) =
-    match result with
-    | Ok r -> Ok r
-    | Error e -> ifErrorFunc e
+    result |> either Ok ifErrorFunc
 
   /// Replaces the wrapped value with unit
   let ignore result =

src/FsToolkit.ErrorHandling/Validation.fs

@@ -45,9 +45,8 @@ module Validation =
   /// The result if the result is Ok, else returns <paramref name="ifError"/>.
   /// </returns>  
   let inline orElse (ifError : Validation<'ok,'error2>) (result : Validation<'ok,'error>) : Validation<'ok,'error2> = 
-    match result with
-    | Ok r -> Ok r
-    | Error _ -> ifError
+    result |> Result.either ok (fun _ -> ifError)
+
 
 
   /// <summary>
@@ -70,9 +69,8 @@ module Validation =
   /// The result if the result is Ok, else the result of executing <paramref name="ifErrorFunc"/>.
   /// </returns>
   let inline orElseWith (ifErrorFunc : 'error list -> Validation<'ok,'error2>) (result : Validation<'ok,'error>) : Validation<'ok,'error2> =
-    match result with
-    | Ok r -> Ok r
-    | Error e -> ifErrorFunc e
+    result |> Result.either ok ifErrorFunc
+
 
   let map f (x : Validation<_,_>) : Validation<_,_>= Result.map f x