Added fsharp-analyzers to fbuild & vscode IDE

Author: 1eyewonder

.config/dotnet-tools.json

@@ -1,30 +1,41 @@
 {
-    "version": 1,
-    "isRoot": true,
-    "tools": {
-        "paket": {
-            "version": "8.0.3",
-            "commands": [
-                "paket"
-            ]
-        },
-        "fable": {
-            "version": "4.4.0",
-            "commands": [
-                "fable"
-            ]
-        },
-        "fantomas": {
-            "version": "6.0.0-alpha-010",
-            "commands": [
-                "fantomas"
-            ]
-        },
-        "femto": {
-            "version": "0.19.0",
-            "commands": [
-                "femto"
-            ]
-        }
+  "version": 1,
+  "isRoot": true,
+  "tools": {
+    "paket": {
+      "version": "8.0.3",
+      "commands": [
+        "paket"
+      ],
+      "rollForward": false
+    },
+    "fable": {
+      "version": "4.4.0",
+      "commands": [
+        "fable"
+      ],
+      "rollForward": false
+    },
+    "fantomas": {
+      "version": "6.0.0-alpha-010",
+      "commands": [
+        "fantomas"
+      ],
+      "rollForward": false
+    },
+    "femto": {
+      "version": "0.19.0",
+      "commands": [
+        "femto"
+      ],
+      "rollForward": false
+    },
+    "fsharp-analyzers": {
+      "version": "0.28.0",
+      "commands": [
+        "fsharp-analyzers"
+      ],
+      "rollForward": false
     }
+  }
 }

.vscode/settings.json

@@ -7,5 +7,7 @@
         "BoundModel.TypeCheck",
         "BackgroundCompiler."
     ],
-    "FSharp.fsac.parallelReferenceResolution": false
+    "FSharp.fsac.parallelReferenceResolution": false,
+    "FSharp.enableAnalyzers": true,
+    "FSharp.analyzersPath": ["packages/analyzers"]
 }

build/build.fs

@@ -136,13 +136,37 @@ module dotnet =
 
     let fantomas args = DotNet.exec id "fantomas" args
 
+    let analyzers args = DotNet.exec id "fsharp-analyzers" args
+
 
 let formatCode _ =
     let result = dotnet.fantomas "."
 
     if not result.OK then
         Trace.traceErrorfn "Errors while formatting all files: %A" result.Messages
 
+let analyze _ =
+    let analyzerPaths = !! "packages/analyzers/**/analyzers/dotnet/fs"
+
+    let createArgsForProject project analyzerPaths =
+        [
+            yield "--project"
+            yield project
+            yield "--analyzers-path"
+            yield! analyzerPaths
+        ]
+        |> String.concat " "
+
+    !! "src/**/*.fsproj"
+    |> Seq.iter (fun fsproj ->
+        let result =
+            createArgsForProject fsproj analyzerPaths
+            |> dotnet.analyzers
+
+        result.Errors
+        |> Seq.iter Trace.traceError
+    )
+
 
 let checkFormatCode _ =
     let result = dotnet.fantomas "--check ."
@@ -443,6 +467,7 @@ let initTargets () =
     Target.create "DotnetPack" dotnetPack
     Target.create "FormatCode" formatCode
     Target.create "CheckFormatCode" checkFormatCode
+    Target.create "Analyzers" analyze
     Target.create "PublishToNuGet" publishNuget
     Target.create "GitRelease" gitRelease
     Target.create "GitHubRelease" githubRelease
@@ -466,6 +491,9 @@ let initTargets () =
     "DotnetRestore"
     ==>! "CheckFormatCode"
 
+    "DotnetRestore"
+    ==>! "Analyzers"
+
     //*** Dotnet Build ***//
     "DotnetRestore"
     ==>! "Build"

paket.dependencies

@@ -56,3 +56,9 @@ group Build
     nuget Nuget.Common >= 6.6.1
     nuget NuGet.Protocol >= 6.6.1
     nuget System.Security.Cryptography.Pkcs >= 7.0.2
+
+group analyzers
+    source https://api.nuget.org/v3/index.json
+
+    nuget Ionide.Analyzers
+    nuget G-Research.FSharp.Analyzers

paket.lock

@@ -24,6 +24,12 @@ NUGET
     System.Threading.Tasks.Extensions (4.5.4) - restriction: == netstandard2.0
       System.Runtime.CompilerServices.Unsafe (>= 4.5.3) - restriction: || (&& (< monoandroid) (< monotouch) (< net45) (>= netstandard1.0) (< netstandard2.0) (< win8) (< wpa81) (< xamarintvos) (< xamarinwatchos)) (&& (< monoandroid) (< netstandard1.0) (>= portable-net45+win8+wp8+wpa81) (< win8)) (&& (>= net45) (< netstandard2.0)) (&& (< net45) (< netcoreapp2.1) (>= netstandard2.0) (< xamarinios) (< xamarinmac) (< xamarintvos) (< xamarinwatchos)) (>= net461) (&& (< netstandard1.0) (>= win8)) (&& (< netstandard2.0) (>= wpa81)) (>= wp8)
 
+GROUP analyzers
+NUGET
+  remote: https://api.nuget.org/v3/index.json
+    G-Research.FSharp.Analyzers (0.12)
+    Ionide.Analyzers (0.13)
+
 GROUP Benchmarks
 STORAGE: NONE
 NUGET