test: remove unneeded -maxorphantx=1000 settings

It's unclear what the motivation for increasing the orphan pool is, and
it seems that this not needed at all. None of these tests involve orphan
transactions explicitly, and if they would occur occasionally, there is
no good reason to prefer a value of 1000 over the default of 100 (see
DEFAULT_MAX_ORPHAN_TRANSACTIONS).

Author: theStack

test/functional/feature_rbf.py

@@ -28,7 +28,6 @@ def set_test_params(self):
         self.num_nodes = 2
         self.extra_args = [
             [
-                "-maxorphantx=1000",
                 "-limitancestorcount=50",
                 "-limitancestorsize=101",
                 "-limitdescendantcount=200",

test/functional/mempool_package_onemore.py

@@ -21,7 +21,6 @@
 class MempoolPackagesTest(BitcoinTestFramework):
     def set_test_params(self):
         self.num_nodes = 1
-        self.extra_args = [["-maxorphantx=1000"]]
 
     def chain_tx(self, utxos_to_spend, *, num_outputs=1):
         return self.wallet.send_self_transfer_multi(

test/functional/mempool_packages.py

@@ -31,10 +31,8 @@ def set_test_params(self):
         self.noban_tx_relay = True
         self.extra_args = [
             [
-                "-maxorphantx=1000",
             ],
             [
-                "-maxorphantx=1000",
                 "-limitancestorcount={}".format(CUSTOM_ANCESTOR_LIMIT),
                 "-limitdescendantcount={}".format(CUSTOM_DESCENDANT_LIMIT),
             ],