Commit c102a55
MacroFake
Merge bitcoin#26179: bench: Add missed
f09d47b bench: Add missed `ECCVerifyHandle` instance (Hennadii Stepanov)
Pull request description:
To clearly observe the lack of an `ECCVerifyHandle` instance,
- apply the following diff:
```diff
--- a/src/Makefile.bench.include
+++ b/src/Makefile.bench.include
@@ -19,11 +19,9 @@ bench_bench_bitcoin_SOURCES = \
bench/bench.h \
bench/bench_bitcoin.cpp \
bench/block_assemble.cpp \
- bench/ccoins_caching.cpp \
bench/chacha20.cpp \
bench/chacha_poly_aead.cpp \
bench/checkblock.cpp \
- bench/checkqueue.cpp \
bench/crypto_hash.cpp \
bench/data.cpp \
bench/data.h \
@@ -46,8 +44,7 @@ bench_bench_bitcoin_SOURCES = \
bench/rpc_blockchain.cpp \
bench/rpc_mempool.cpp \
bench/strencodings.cpp \
- bench/util_time.cpp \
- bench/verify_script.cpp
+ bench/util_time.cpp
nodist_bench_bench_bitcoin_SOURCES = $(GENERATED_BENCH_FILES)
```
- then
```
$ ./autogen
$ ./configure
$ make clean
$ make
```
- then
```
$ ./src/bench/bench_bitcoin -filter=ExpandDescriptor
bench_bitcoin: pubkey.cpp:296: bool CPubKey::IsFullyValid() const: Assertion `secp256k1_context_verify && "secp256k1_context_verify must be initialized to use CPubKey."' failed.
Aborted (core dumped)
```
ACKs for top commit:
achow101:
ACK f09d47b
w0xlt:
ACK bitcoin@f09d47b
Tree-SHA512: e1f33f88d427c57fe31d5810d12e9f46fed2911f5736208ebf7d4a968de0dd8c1f6b73a0d1093316da117dd3bcfda5dde6e41d6c95fcdb99bdea62e19df5ad20ECCVerifyHandle instance1 file changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
| |||
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
| 32 | + | |
| 33 | + | |
28 | 34 | | |
29 | 35 | | |
30 | 36 | | |
0 commit comments