test: Target exact weight in MiniWallet _bulk_tx

Also, replace broad -acceptnonstdtxn=1 with -datacarriersize=100000

Author: MacroFake

test/functional/mempool_package_limits.py

@@ -35,8 +35,8 @@ def run_test(self):
         self.test_anc_count_limits_2()
         self.test_anc_count_limits_bushy()
 
-        # The node will accept our (nonstandard) extra large OP_RETURN outputs
-        self.restart_node(0, extra_args=["-acceptnonstdtxn=1"])
+        # The node will accept (nonstandard) extra large OP_RETURN outputs
+        self.restart_node(0, extra_args=["-datacarriersize=100000"])
         self.test_anc_size_limits()
         self.test_desc_size_limits()
 

test/functional/test_framework/wallet.py

@@ -39,6 +39,7 @@
     LegacySignatureHash,
     LEAF_VERSION_TAPSCRIPT,
     OP_NOP,
+    OP_RETURN,
     OP_TRUE,
     SIGHASH_ALL,
     taproot_construct,
@@ -107,11 +108,13 @@ def _bulk_tx(self, tx, target_weight):
         """Pad a transaction with extra outputs until it reaches a target weight (or higher).
         returns the tx
         """
-        assert_greater_than_or_equal(target_weight, tx.get_weight())
-        while tx.get_weight() < target_weight:
-            script_pubkey = ( b"6a4d0200"  # OP_RETURN OP_PUSH2 512 bytes
-                + b"01" * 512 )
-            tx.vout.append(CTxOut(0, script_pubkey))
+        tx.vout.append(CTxOut(nValue=0, scriptPubKey=CScript([OP_RETURN, b'a'])))
+        dummy_vbytes = (target_weight - tx.get_weight() + 3) // 4
+        tx.vout[-1].scriptPubKey = CScript([OP_RETURN, b'a' * dummy_vbytes])
+        # Lower bound should always be off by at most 3
+        assert_greater_than_or_equal(tx.get_weight(), target_weight)
+        # Higher bound should always be off by at most 3 + 12 weight (for encoding the length)
+        assert_greater_than_or_equal(target_weight + 15, tx.get_weight())
 
     def get_balance(self):
         return sum(u['value'] for u in self._utxos)