Skip to content

Commit 4ff92a1

Browse files
authored
Den 317 rewrite remote browser to use dendrite (#62)
* add first version of update remote implementation * update remote to use dendrite with remote_config * add remote browser config classes * refactor remote browser impl and settings * update generate_sync to create folder if not existing * add browserbaser download test * remove unnecessary log * rename ext module to remote * fix bug when launching browser missing browser context * update ci action to have correct env * add raise exception for failed browserbase session creation
1 parent 062791a commit 4ff92a1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+1271
-1253
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ on:
1111
- main
1212

1313

14+
1415
jobs:
1516
lint:
1617
runs-on: ubuntu-latest
@@ -47,6 +48,9 @@ jobs:
4748

4849
test:
4950
runs-on: ubuntu-latest
51+
env:
52+
BROWSERBASE_API_KEY: ${{ secrets.BROWSERBASE_API_KEY }}
53+
BROWSERBASE_PROJECT_ID: ${{ secrets.BROWSERBASE_PROJECT_ID }}
5054
steps:
5155
- uses: actions/checkout@v4
5256

dendrite_sdk/_common/_exceptions/dendrite_exception.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class BaseDendriteException(Exception):
2121

2222
def __init__(self, message: str, screenshot_base64: Optional[str] = None) -> None:
2323
self._message = message
24-
logger.error(self)
24+
logger.exception(self)
2525
super().__init__(message)
2626

2727
@property
@@ -136,8 +136,6 @@ def __init__(
136136
class DendriteException(BaseDendriteException):
137137
"""
138138
General exception class for Dendrite errors, including optional screenshot and additional metadata.
139-
140-
Inherits from BaseDendriteException.
141139
"""
142140

143141
def __init__(self, message: str, screenshot_base64: str = "") -> None:
@@ -154,6 +152,10 @@ def __init__(self, message: str, screenshot_base64: str = "") -> None:
154152
self._stack: Optional[str] = None
155153
super().__init__(message)
156154

155+
@property
156+
def message(self) -> str:
157+
return self._message
158+
157159
@property
158160
def name(self) -> Optional[str]:
159161
"""

0 commit comments

Comments
 (0)