First version

Author: dennisdoomen

Build/Build.cs

@@ -154,15 +154,21 @@ class Build : NukeBuild
                 .WhenNotNull(SemVer, (c, semVer) => c
                     .AddPair("Packed version", semVer)));
 
+            Project[] projects = [
+                Solution.GetProject("Pathy"),
+                Solution.GetProject("Pathy.Globbing")
+            ];
+
             DotNetPack(s => s
-                .SetProject(Solution.GetProject("Pathy"))
-                .SetOutputDirectory(ArtifactsDirectory)
-                .SetConfiguration(Configuration == Configuration.Debug ? "Debug" : "Release")
-                .EnableNoBuild()
-                .EnableNoLogo()
-                .EnableNoRestore()
-                .EnableContinuousIntegrationBuild() // Necessary for deterministic builds
-                .SetVersion(SemVer));
+                .CombineWith(projects, (settings, project) => settings
+                    .SetProject(project)
+                    .SetOutputDirectory(ArtifactsDirectory)
+                    .SetConfiguration(Configuration == Configuration.Debug ? "Debug" : "Release")
+                    .EnableNoBuild()
+                    .EnableNoLogo()
+                    .EnableNoRestore()
+                    .EnableContinuousIntegrationBuild() // Necessary for deterministic builds
+                .SetVersion(SemVer)));
         });
 
     Target Push => _ => _

Directory.Build.props

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <LangVersion>11.0</LangVersion>
     <CheckEolTargetFramework>false</CheckEolTargetFramework>
-    <WarningsNotAsErrors>$(WarningsNotAsErrors);NU1902;NU1903</WarningsNotAsErrors> <!-- disable EOL warnings -->
+    <WarningsNotAsErrors>$(WarningsNotAsErrors);NU1900;NU1902;NU1903</WarningsNotAsErrors> <!-- disable EOL warnings -->
     <NoWarn>1591;1573</NoWarn>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>

Pathy.ApiVerificationTests/ApiApproval.cs

@@ -1,6 +1,4 @@
-using System.IO;
-using System.Linq;
-using System.Reflection;
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
 using System.Xml.Linq;
@@ -18,36 +16,45 @@ public class ApiApproval
     static ApiApproval() => VerifyDiffPlex.Initialize(OutputType.Minimal);
 
     [Theory]
-    [ClassData(typeof(TargetFrameworksTheoryData))]
-    public Task ApproveApi(string framework)
+    [InlineData("netstandard2.0")]
+    [InlineData("netstandard2.1")]
+    [InlineData("net47")]
+    [InlineData("net8.0")]
+    public async Task ApprovePathyApi(string targetFramework)
     {
         var configuration = typeof(ApiApproval).Assembly.GetCustomAttribute<AssemblyConfigurationAttribute>()!.Configuration;
-        var assemblyFile = CombinedPaths("Pathy", "bin", configuration, framework, "Pathy.dll");
+        var assemblyFile = GetSolutionDirectory() / "Pathy" / "bin" / configuration / targetFramework / "Pathy.dll";
         var assembly = Assembly.LoadFile(assemblyFile);
         var publicApi = assembly.GeneratePublicApi(options: null);
 
-        return Verifier
+        await Verifier
             .Verify(publicApi)
             .ScrubLinesContaining("FrameworkDisplayName")
             .UseDirectory("ApprovedApi")
-            .UseFileName(framework)
+            .UseFileName("pathy." + targetFramework)
             .DisableDiff();
     }
 
-    private class TargetFrameworksTheoryData : TheoryData<string>
+    [Theory]
+    [InlineData("netstandard2.0")]
+    [InlineData("netstandard2.1")]
+    [InlineData("net47")]
+    [InlineData("net8.0")]
+    public async Task ApprovePathyGlobbingApi(string targetFramework)
     {
-        public TargetFrameworksTheoryData()
-        {
-            var csproj = CombinedPaths("Pathy", "Pathy.csproj");
-            var project = XDocument.Load(csproj);
-            var targetFrameworks = project.XPathSelectElement("/Project/PropertyGroup/TargetFrameworks");
-            AddRange(targetFrameworks!.Value.Split(';'));
-        }
-    }
+        var configuration = typeof(ApiApproval).Assembly.GetCustomAttribute<AssemblyConfigurationAttribute>()!.Configuration;
+        var assemblyFile = GetSolutionDirectory() / "Pathy.Globbing" / "bin" / configuration / targetFramework / "Pathy.Globbing.dll";
+        var assembly = Assembly.LoadFile(assemblyFile);
+        var publicApi = assembly.GeneratePublicApi(options: null);
 
-    private static string CombinedPaths(params string[] paths) =>
-        Path.GetFullPath(Path.Combine(paths.Prepend(GetSolutionDirectory()).ToArray()));
+        await Verifier
+            .Verify(publicApi)
+            .ScrubLinesContaining("FrameworkDisplayName")
+            .UseDirectory("ApprovedApi")
+            .UseFileName("pathy.globbing." + targetFramework)
+            .DisableDiff();
+    }
 
-    private static string GetSolutionDirectory([CallerFilePath] string path = "") =>
-        Path.Combine(Path.GetDirectoryName(path)!, "..");
+    private static ChainablePath GetSolutionDirectory([CallerFilePath] string path = "") =>
+        ChainablePath.From(path).Directory / "..";
 }

Pathy.ApiVerificationTests/ApprovedApi/net47.verified.txt

@@ -0,0 +1 @@
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Pathy.Specs")]

Pathy.ApiVerificationTests/ApprovedApi/net8.0.verified.txt

@@ -0,0 +1 @@
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Pathy.Specs")]

Pathy.ApiVerificationTests/ApprovedApi/netstandard2.0.verified.txt

@@ -0,0 +1 @@
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("Pathy.Specs")]