chore(internal): move TypedEventTarget from events.ts to typed_event_target.ts (#574)

Author: uki00a

connection.ts

@@ -5,8 +5,12 @@ import {
   InvalidStateError,
   isRetriableError,
 } from "./errors.ts";
-import type { ConnectionEventMap, TypedEventTarget } from "./events.ts";
-import { createTypedEventTarget, dispatchEvent } from "./events.ts";
+import type { ConnectionEventMap } from "./events.ts";
+import type { TypedEventTarget } from "./internal/typed_event_target.ts";
+import {
+  createTypedEventTarget,
+  dispatchEvent,
+} from "./internal/typed_event_target.ts";
 import {
   kUnstableCreateProtocol,
   kUnstablePipeline,

events.ts

@@ -1,47 +1,3 @@
-export interface TypedEventTarget<TEventMap extends Record<string, unknown>>
-  extends
-    Omit<
-      EventTarget,
-      "addEventListener" | "removeEventListener" | "dispatchEvent"
-    > {
-  addEventListener<K extends keyof TEventMap>(
-    type: K,
-    callback: (
-      event: CustomEvent<TEventMap[K]>,
-    ) => void,
-    options?: AddEventListenerOptions | boolean,
-  ): void;
-
-  removeEventListener<K extends keyof TEventMap>(
-    type: K,
-    callback: (
-      event: CustomEvent<TEventMap[K]>,
-    ) => void,
-    options?: EventListenerOptions | boolean,
-  ): void;
-}
-
-export function createTypedEventTarget<
-  TEventMap extends Record<string, unknown>,
->(): TypedEventTarget<TEventMap> {
-  return new EventTarget() as TypedEventTarget<TEventMap>;
-}
-
-export function dispatchEvent<
-  TEventMap extends Record<string, unknown>,
-  TKey extends Extract<keyof TEventMap, string>,
->(
-  eventTarget: TypedEventTarget<TEventMap>,
-  event: TKey,
-  detail: TEventMap[TKey],
-): boolean {
-  return (eventTarget as EventTarget).dispatchEvent(
-    new CustomEvent(event, {
-      detail,
-    }),
-  );
-}
-
 export type ConnectionEvent = Record<string, unknown>;
 
 export type ConnectionErrorEventDetails = {

internal/typed_event_target.ts

@@ -0,0 +1,43 @@
+export interface TypedEventTarget<TEventMap extends Record<string, unknown>>
+  extends
+    Omit<
+      EventTarget,
+      "addEventListener" | "removeEventListener" | "dispatchEvent"
+    > {
+  addEventListener<K extends keyof TEventMap>(
+    type: K,
+    callback: (
+      event: CustomEvent<TEventMap[K]>,
+    ) => void,
+    options?: AddEventListenerOptions | boolean,
+  ): void;
+
+  removeEventListener<K extends keyof TEventMap>(
+    type: K,
+    callback: (
+      event: CustomEvent<TEventMap[K]>,
+    ) => void,
+    options?: EventListenerOptions | boolean,
+  ): void;
+}
+
+export function createTypedEventTarget<
+  TEventMap extends Record<string, unknown>,
+>(): TypedEventTarget<TEventMap> {
+  return new EventTarget() as TypedEventTarget<TEventMap>;
+}
+
+export function dispatchEvent<
+  TEventMap extends Record<string, unknown>,
+  TKey extends Extract<keyof TEventMap, string>,
+>(
+  eventTarget: TypedEventTarget<TEventMap>,
+  event: TKey,
+  detail: TEventMap[TKey],
+): boolean {
+  return (eventTarget as EventTarget).dispatchEvent(
+    new CustomEvent(event, {
+      detail,
+    }),
+  );
+}

redis.ts

@@ -49,11 +49,8 @@ import type { Connection, SendCommandOptions } from "./connection.ts";
 import type { RedisConnectionOptions } from "./connection.ts";
 import type { Client, RedisSubscription } from "./client.ts";
 import { createDefaultClient } from "./default_client.ts";
-import type {
-  ConnectionEventMap,
-  ConnectionEventType,
-  TypedEventTarget,
-} from "./events.ts";
+import type { ConnectionEventMap, ConnectionEventType } from "./events.ts";
+import type { TypedEventTarget } from "./internal/typed_event_target.ts";
 import type {
   Binary,
   Bulk,