Skip to content

Commit c61a1c6

Browse files
agrievecopybara-github
authored andcommitted
Allow test() targets to specify additional_apks
Bug: 381000093 Change-Id: I3d886ec49874ef2bfbcddd4e8454bc3e2715d5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253565 Reviewed-by: Peter Wen <[email protected]> Auto-Submit: Andrew Grieve <[email protected]> Commit-Queue: Peter Wen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1419272} NOKEYCHECK=True GitOrigin-RevId: a918301a44925e32015410767382fc333d7e8ee2
1 parent c8dd385 commit c61a1c6

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

config/android/internal_rules.gni

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,12 +734,21 @@ template("test_runner_script") {
734734
"public_deps",
735735
])
736736
data_deps = []
737+
if (defined(invoker.apk_target)) {
738+
data_deps += [ invoker.apk_target ]
739+
}
737740
if (defined(invoker.data_deps)) {
738741
data_deps += invoker.data_deps
739742
}
743+
if (defined(invoker.apk_under_test)) {
744+
data_deps += [ invoker.apk_under_test ]
745+
}
740746
if (defined(invoker.additional_apks)) {
741747
data_deps += invoker.additional_apks
742748
}
749+
if (defined(invoker.data_deps)) {
750+
data_deps += invoker.data_deps
751+
}
743752
write_runtime_deps = _runtime_deps_file
744753
}
745754
}

config/android/rules.gni

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3654,16 +3654,7 @@ if (!is_robolectric && enable_java_templates) {
36543654
apk_target = invoker.android_test_apk
36553655
incremental_apk = _incremental_apk
36563656

3657-
public_deps = [
3658-
":$_apk_operations_target_name",
3659-
apk_target,
3660-
]
3661-
if (defined(invoker.apk_under_test)) {
3662-
public_deps += [ invoker.apk_under_test ]
3663-
}
3664-
if (defined(invoker.additional_apks)) {
3665-
public_deps += invoker.additional_apks
3666-
}
3657+
public_deps = [ ":$_apk_operations_target_name" ]
36673658
if (use_rts) {
36683659
if (!defined(data_deps)) {
36693660
data_deps = []

0 commit comments

Comments
 (0)