Skip to content

Commit f78a175

Browse files
DKLoehrcopybara-github
authored andcommitted
Enable -Wcharacter-conversion
Now that the pdfium fix has rolled in, we should be able to build with this warning enabled. Bug: 417996267 Change-Id: I986a55739cefb4bfc9744ca60613c71d9e4292d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6674713 Reviewed-by: Hans Wennborg <[email protected]> Commit-Queue: Devon Loehr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1479782} NOKEYCHECK=True GitOrigin-RevId: f1cdd12cc7a8b10cf24f3442c45e9e72565eb7bb
1 parent 71876cf commit f78a175

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

config/compiler/BUILD.gn

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2107,12 +2107,6 @@ config("default_warnings") {
21072107
]
21082108
}
21092109

2110-
if (default_toolchain != "//build/toolchain/cros:target" &&
2111-
!llvm_android_mainline) {
2112-
# TODO(crbug.com/417996267): Fix and re-enable
2113-
cflags += [ "-Wno-character-conversion" ]
2114-
}
2115-
21162110
if (is_component_build && use_clang_warning_suppression_file && !is_win) {
21172111
# Warn for globally unique objects which might get duplicated if built
21182112
# into different components, due to hidden visibility. Only applicable

0 commit comments

Comments
 (0)