Skip to content

Commit f8fa642

Browse files
zetafunctioncopybara-github
authored andcommitted
Delete NaCl toolchain definitions
Bug: 40511454 Change-Id: I773cba4f4959dfbe1862bea8b8d3d91347c6128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6669399 Reviewed-by: Hans Wennborg <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1479872} NOKEYCHECK=True GitOrigin-RevId: 13b8bccaa1867b29b9850350db1605bdcb5723cc
1 parent 3e06931 commit f8fa642

File tree

5 files changed

+0
-188
lines changed

5 files changed

+0
-188
lines changed

toolchain/cros/BUILD.gn

Lines changed: 0 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -93,88 +93,6 @@ cros_toolchain("target") {
9393
}
9494
}
9595

96-
# This is a special toolchain needed just for the nacl_bootstrap target in
97-
# //native_client/src/trusted/service_runtime/linux. It is identical
98-
# to ":target" except that it forces `use_debug_fission1 and `use_sysroot` off,
99-
# and allows the user to set different sets of extra flags.
100-
cros_toolchain("nacl_bootstrap") {
101-
toolchain_args = {
102-
if (target_cpu == "arm64") {
103-
current_cpu = "arm"
104-
} else {
105-
current_cpu = target_cpu
106-
}
107-
current_os = "chromeos"
108-
use_debug_fission = false
109-
use_sysroot = false
110-
}
111-
112-
if (!lacros_use_chromium_toolchain) {
113-
ar = cros_target_ar
114-
cc = cros_target_cc
115-
cxx = cros_target_cxx
116-
ld = cros_target_ld
117-
118-
if (cros_target_nm != "") {
119-
nm = cros_target_nm
120-
}
121-
if (cros_target_readelf != "") {
122-
readelf = cros_target_readelf
123-
}
124-
extra_cflags = cros_nacl_bootstrap_extra_cflags
125-
extra_cppflags = cros_nacl_bootstrap_extra_cppflags
126-
extra_cxxflags = cros_nacl_bootstrap_extra_cxxflags
127-
extra_ldflags = cros_nacl_bootstrap_extra_ldflags
128-
129-
needs_rewrapper_path_arg = cros_needs_rewrapper_path_arg
130-
}
131-
132-
# We build for ARM32, even when the rest of the build targets ARM64.
133-
if (target_cpu == "arm64") {
134-
ar = cros_nacl_helper_arm32_ar
135-
cc = cros_nacl_helper_arm32_cc
136-
cxx = cros_nacl_helper_arm32_cxx
137-
ld = cros_nacl_helper_arm32_ld
138-
139-
# Avoid accidental use of Arm64 sysroot because of SYSROOT
140-
# env variable set in ChromeOS builds.
141-
toolchain_args.sysroot = cros_nacl_helper_arm32_sysroot
142-
}
143-
}
144-
145-
# This is a special toolchain needed just for the nacl_helper target for
146-
# building an Arm32 nacl_helper binary on Arm64 ChromeOS targets.
147-
cros_toolchain("nacl_helper_arm32") {
148-
toolchain_args = {
149-
current_cpu = "arm"
150-
current_os = "chromeos"
151-
use_debug_fission = false
152-
sysroot = cros_nacl_helper_arm32_sysroot
153-
154-
# Disable some uses of libraries that this build does not require. The
155-
# sysroot for this build does not provide them, and they would be pulled in
156-
# by indirect dependencies of nacl_helper otherwise.
157-
use_cras = false
158-
use_nss_certs = false
159-
use_system_libdrm = false
160-
use_system_libsync = false
161-
}
162-
ar = cros_nacl_helper_arm32_ar
163-
cc = cros_nacl_helper_arm32_cc
164-
cxx = cros_nacl_helper_arm32_cxx
165-
ld = cros_nacl_helper_arm32_ld
166-
readelf = cros_nacl_helper_arm32_readelf
167-
168-
extra_cflags = ""
169-
extra_cppflags = ""
170-
extra_cxxflags = ""
171-
extra_ldflags = ""
172-
173-
if (!lacros_use_chromium_toolchain) {
174-
needs_rewrapper_path_arg = cros_needs_rewrapper_path_arg
175-
}
176-
}
177-
17896
cros_toolchain("host") {
17997
toolchain_args = {
18098
current_cpu = host_cpu

toolchain/cros_toolchain.gni

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,22 +70,10 @@ declare_args() {
7070
cros_v8_snapshot_extra_cxxflags = ""
7171
cros_v8_snapshot_extra_ldflags = ""
7272
cros_v8_snapshot_sysroot = ""
73-
74-
cros_nacl_bootstrap_extra_cflags = ""
75-
cros_nacl_bootstrap_extra_cppflags = ""
76-
cros_nacl_bootstrap_extra_cxxflags = ""
77-
cros_nacl_bootstrap_extra_ldflags = ""
78-
79-
cros_nacl_helper_arm32_ar = "${clang_base_path}/bin/llvm-ar"
80-
cros_nacl_helper_arm32_cc = "${clang_base_path}/bin/clang"
81-
cros_nacl_helper_arm32_cxx = "${clang_base_path}/bin/clang++"
82-
cros_nacl_helper_arm32_readelf = ""
83-
cros_nacl_helper_arm32_sysroot = ""
8473
}
8574

8675
declare_args() {
8776
cros_target_ld = cros_target_cxx
8877
cros_host_ld = cros_host_cxx
8978
cros_v8_snapshot_ld = cros_v8_snapshot_cxx
90-
cros_nacl_helper_arm32_ld = cros_nacl_helper_arm32_cxx
9179
}

toolchain/gcc_toolchain.gni

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@ import("//build/toolchain/cc_wrapper.gni")
1313
import("//build/toolchain/rbe.gni")
1414
import("//build/toolchain/toolchain.gni")
1515

16-
if (is_nacl) {
17-
# To keep NaCl variables out of builds that don't include NaCl, all
18-
# variables defined in nacl/config.gni referenced here should be protected by
19-
# is_nacl conditions.
20-
import("//build/config/nacl/config.gni")
21-
}
22-
2316
declare_args() {
2417
# Enables allowlist generation for IDR_ grit defines seen by the compiler.
2518
# Currently works only on some platforms and enabled by default for official

toolchain/nacl_toolchain.gni

Lines changed: 0 additions & 75 deletions
This file was deleted.

toolchain/win/BUILD.gn

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,18 +48,6 @@ if (target_cpu == "arm64") {
4848
}
4949
}
5050

51-
# The nacl_win64 toolchain is nearly identical to the plain x64 toolchain.
52-
# It's used solely for building nacl64.exe (//components/nacl/broker:nacl64).
53-
# The only reason it's a separate toolchain is so that it can force
54-
# is_component_build to false in the toolchain_args() block, because
55-
# building nacl64.exe in component style does not work.
56-
win_toolchains("nacl_win64") {
57-
toolchain_arch = "x64"
58-
toolchain_args = {
59-
is_component_build = false
60-
}
61-
}
62-
6351
# WinUWP toolchains. Only define these when targeting them.
6452

6553
if (target_os == "winuwp") {

0 commit comments

Comments
 (0)