refactor: update deno_core (#31607)

For denoland/deno_core#1262

Author: crowlKats

Cargo.lock

@@ -66,7 +66,7 @@ repository = "https://github.com/denoland/deno"
 
 [workspace.dependencies]
 deno_ast = { version = "=0.52.0", features = ["transpiling"] }
-deno_core = { version = "0.381.1" }
+deno_core = { version = "0.382.0" }
 
 deno_cache_dir = "=0.26.3"
 deno_doc = "=0.189.1"

Cargo.toml

@@ -4746,7 +4746,6 @@ fn op_is_node_file(state: &mut OpState, #[string] path: String) -> bool {
 }
 
 #[op2]
-#[serde]
 fn op_libs() -> Vec<String> {
   crate::tsc::lib_names()
 }
@@ -4841,12 +4840,11 @@ fn op_release(
 }
 
 #[op2]
-#[serde]
 #[allow(clippy::type_complexity)]
 fn op_resolve(
   state: &mut OpState,
   #[string] base: &str,
-  #[serde] specifiers: Vec<(bool, String)>,
+  #[scoped] specifiers: Vec<(bool, String)>,
 ) -> Result<Vec<Option<(String, Option<String>)>>, deno_core::url::ParseError> {
   let _span = super::logging::lsp_tracing_info_span!("op_resolve").entered();
   op_resolve_inner(state, ResolveArgs { base, specifiers })
@@ -4899,8 +4897,7 @@ impl<'a> ToV8<'a> for TscRequestArray {
   }
 }
 
-#[op2(async)]
-#[to_v8]
+#[op2]
 async fn op_poll_requests(
   state: Rc<RefCell<OpState>>,
 ) -> convert::OptionNull<TscRequestArray> {

cli/lsp/tsc.rs

@@ -99,7 +99,7 @@ static NEXT_ID: AtomicUsize = AtomicUsize::new(0);
 #[op2]
 fn op_register_bench(
   state: &mut OpState,
-  #[global] function: v8::Global<v8::Function>,
+  #[scoped] function: v8::Global<v8::Function>,
   #[string] name: String,
   baseline: bool,
   #[string] group: Option<String>,

cli/ops/bench.rs

@@ -122,7 +122,7 @@ pub enum JupyterBroadcastError {
   ZeroMq(AnyError),
 }
 
-#[op2(async)]
+#[op2]
 pub async fn op_jupyter_broadcast(
   state: Rc<RefCell<OpState>>,
   #[string] message_type: String,
@@ -355,7 +355,6 @@ pub fn op_jupyter_create_png_from_texture(
 }
 
 #[op2]
-#[serde]
 pub fn op_jupyter_get_buffer(
   #[cppgc] buffer: &deno_runtime::deno_webgpu::buffer::GPUBuffer,
 ) -> Result<Vec<u8>, deno_runtime::deno_webgpu::error::GPUError> {

cli/ops/jupyter.rs

@@ -6,7 +6,9 @@ use deno_ast::ParseDiagnostic;
 use deno_ast::SourceRange;
 use deno_ast::SourceTextInfo;
 use deno_ast::SourceTextProvider;
+use deno_core::FromV8;
 use deno_core::OpState;
+use deno_core::convert::Uint8Array;
 use deno_core::op2;
 use deno_lint::diagnostic::LintDiagnostic;
 use deno_lint::diagnostic::LintDiagnosticDetails;
@@ -204,12 +206,11 @@ pub enum LintError {
 }
 
 #[op2]
-#[buffer]
 #[allow(clippy::result_large_err)]
 fn op_lint_create_serialized_ast(
   #[string] file_name: &str,
   #[string] source: String,
-) -> Result<Vec<u8>, LintError> {
+) -> Result<Uint8Array, LintError> {
   let file_text = deno_ast::strip_bom(source);
   let path = std::env::current_dir()?.join(file_name);
   let specifier = ModuleSpecifier::from_file_path(&path)
@@ -224,10 +225,10 @@ fn op_lint_create_serialized_ast(
     maybe_syntax: None,
   })?;
   let utf16_map = Utf16Map::new(parsed_source.text().as_ref());
-  Ok(lint::serialize_ast_to_buffer(&parsed_source, &utf16_map))
+  Ok(lint::serialize_ast_to_buffer(&parsed_source, &utf16_map).into())
 }
 
-#[derive(serde::Deserialize)]
+#[derive(FromV8)]
 struct LintReportFix {
   text: String,
   range: (usize, usize),
@@ -254,7 +255,7 @@ fn op_lint_report(
   #[string] hint: Option<String>,
   #[smi] start_utf16: usize,
   #[smi] end_utf16: usize,
-  #[serde] fix: Vec<LintReportFix>,
+  #[scoped] fix: Vec<LintReportFix>,
 ) -> Result<(), LintReportError> {
   let container = state.borrow_mut::<LintPluginContainer>();
   container.report(id, message, hint, start_utf16, end_utf16, fix)?;

cli/ops/lint.rs

@@ -95,7 +95,7 @@ static NEXT_ID: AtomicUsize = AtomicUsize::new(0);
 #[op2]
 fn op_register_test(
   state: &mut OpState,
-  #[global] function: v8::Global<v8::Function>,
+  #[scoped] function: v8::Global<v8::Function>,
   #[string] name: String,
   ignore: bool,
   only: bool,
@@ -139,7 +139,7 @@ fn op_register_test(
 fn op_register_test_hook(
   state: &mut OpState,
   #[string] hook_type: String,
-  #[global] function: v8::Global<v8::Function>,
+  #[scoped] function: v8::Global<v8::Function>,
 ) -> Result<(), JsErrorBox> {
   let container = state.borrow_mut::<TestContainer>();
   container.register_hook(hook_type, function);

cli/ops/testing.rs

@@ -74,7 +74,7 @@ fn convert_build_output_file(
 ) -> rt_bundle::BuildOutputFile {
   rt_bundle::BuildOutputFile {
     path: file.path,
-    contents: Some(file.contents),
+    contents: Some(file.contents.into()),
     hash: file.hash,
   }
 }

cli/tools/bundle/provider.rs

@@ -51,17 +51,15 @@ fn op_remap_specifier(
 }
 
 #[op2]
-#[serde]
 fn op_libs() -> Vec<String> {
   crate::tsc::lib_names()
 }
 
 #[op2]
-#[serde]
 fn op_resolve(
   state: &mut OpState,
   #[string] base: &str,
-  #[serde] specifiers: Vec<(bool, String)>,
+  #[scoped] specifiers: Vec<(bool, String)>,
 ) -> Result<Vec<(String, Option<&'static str>)>, ResolveError> {
   op_resolve_inner(state, ResolveArgs { base, specifiers })
 }

cli/tsc/js.rs

@@ -5,7 +5,10 @@ use std::rc::Rc;
 use std::sync::Arc;
 
 use async_trait::async_trait;
+use deno_core::FromV8;
 use deno_core::OpState;
+use deno_core::ToV8;
+use deno_core::convert::Uint8Array;
 use deno_core::error::AnyError;
 use deno_core::op2;
 use deno_error::JsErrorBox;
@@ -53,38 +56,31 @@ pub trait BundleProvider: Send + Sync {
   ) -> Result<BuildResponse, AnyError>;
 }
 
-#[derive(Clone, Debug, Eq, PartialEq, Default, serde::Deserialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Clone, Debug, Eq, PartialEq, Default, FromV8)]
 pub struct BundleOptions {
   pub entrypoints: Vec<String>,
-  #[serde(default)]
   pub output_path: Option<String>,
-  #[serde(default)]
   pub output_dir: Option<String>,
-  #[serde(default)]
+  #[from_v8(default)]
   pub external: Vec<String>,
-  #[serde(default)]
+  #[from_v8(serde, default)]
   pub format: BundleFormat,
-  #[serde(default)]
+  #[from_v8(default)]
   pub minify: bool,
-  #[serde(default)]
+  #[from_v8(default)]
   pub code_splitting: bool,
-  #[serde(default = "tru")]
+  #[from_v8(default = true)]
   pub inline_imports: bool,
-  #[serde(default)]
+  #[from_v8(serde, default)]
   pub packages: PackageHandling,
-  #[serde(default)]
+  #[from_v8(serde)]
   pub sourcemap: Option<SourceMapType>,
-  #[serde(default)]
+  #[from_v8(serde, default)]
   pub platform: BundlePlatform,
-  #[serde(default = "tru")]
+  #[from_v8(default = true)]
   pub write: bool,
 }
 
-fn tru() -> bool {
-  true
-}
-
 #[derive(Clone, Debug, Eq, PartialEq, Copy, Default, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub enum BundlePlatform {
@@ -147,16 +143,14 @@ impl std::fmt::Display for PackageHandling {
     }
   }
 }
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, FromV8, ToV8)]
 pub struct Message {
   pub text: String,
   pub location: Option<Location>,
   pub notes: Vec<Note>,
 }
 
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, FromV8, ToV8)]
 pub struct PartialMessage {
   pub id: Option<String>,
   pub plugin_name: Option<String>,
@@ -166,28 +160,24 @@ pub struct PartialMessage {
   pub detail: Option<u32>,
 }
 
-#[derive(Debug, Clone, serde::Serialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, ToV8)]
 pub struct BuildOutputFile {
   pub path: String,
-  pub contents: Option<Vec<u8>>,
+  pub contents: Option<Uint8Array>,
   pub hash: String,
 }
-#[derive(Debug, Clone, serde::Serialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, ToV8)]
 pub struct BuildResponse {
   pub errors: Vec<Message>,
   pub warnings: Vec<Message>,
   pub output_files: Option<Vec<BuildOutputFile>>,
 }
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, FromV8, ToV8)]
 pub struct Note {
   pub text: String,
   pub location: Option<Location>,
 }
-#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
-#[serde(rename_all = "camelCase")]
+#[derive(Debug, Clone, FromV8, ToV8)]
 pub struct Location {
   pub file: String,
   pub namespace: Option<String>,
@@ -222,11 +212,10 @@ pub struct OnLoadOptions {
   pub namespace: Option<String>,
 }
 
-#[op2(async)]
-#[serde]
+#[op2]
 pub async fn op_bundle(
   state: Rc<RefCell<OpState>>,
-  #[serde] options: BundleOptions,
+  #[scoped] options: BundleOptions,
 ) -> Result<BuildResponse, JsErrorBox> {
   // eprintln!("op_bundle: {:?}", options);
   let provider = {