Skip to content

Commit 17cdcc2

Browse files
authored
feat(node): allow subpath imports that start with '#/' (#31520)
Ref: nodejs/node#60864
1 parent a15cafe commit 17cdcc2

File tree

6 files changed

+18
-1
lines changed

6 files changed

+18
-1
lines changed

libs/node_resolver/resolution.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ impl<
10361036
conditions: &[Cow<'static, str>],
10371037
resolution_kind: NodeResolutionKind,
10381038
) -> Result<MaybeTypesResolvedUrl, PackageImportsResolveError> {
1039-
if name == "#" || name.starts_with("#/") || name.ends_with('/') {
1039+
if name == "#" || name.ends_with('/') {
10401040
let reason = "is not a valid internal imports specifier name";
10411041
return Err(
10421042
errors::InvalidModuleSpecifierError {
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"args": "run main.js",
3+
"output": "main.out"
4+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { add } from "#/add";
2+
3+
console.log(add(1, 2));
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"type": "module",
3+
"imports": {
4+
"#/*": "./src/*.js"
5+
}
6+
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export function add(a, b) {
2+
return a + b;
3+
}

0 commit comments

Comments
 (0)