extends field in tsconfig.json

[EarlMilktea]

Is it possible to, for example, use this

{
  "extends": ["@tsconfig/vite-react/tsconfig.json"]
}

rather than this?

{
  "extends": ["./node_modules/@tsconfig/vite-react/tsconfig.json"]
}

I noticed that the former is apparently not working correctly, and am curious about whether it is supported in the first place.
Thanks in advance!

[nayeemrmn]

The first one is supposed to work, are you sure you have a node_modules folder with that package in it?

[EarlMilktea]

Yes of course! Actually I did some experiments and verified it.
Using the commit df6daee , I added dbg!(extends_targets.len()); at libs/resolver/deno_json.rs:1195:5 and ran the command in CONTRIBUTING.md .

With the former tsconfig.json the output is like this:

$ ./target/debug/deno run --config tsconfig.json ./tests/testdata/run/002_hello.ts 
[libs/resolver/deno_json.rs:1195:5] extends_targets.len() = 0
Hello World

but with the latter it is:

$ ./target/debug/deno run --config tsconfig.json ./tests/testdata/run/002_hello.ts 
[libs/resolver/deno_json.rs:1195:5] extends_targets.len() = 0
[libs/resolver/deno_json.rs:1195:5] extends_targets.len() = 1
Hello World

I'm not completely sure what's going on (especially the reason why dbg! is evaluated twice), but it's very likely that at least for the former extends field is not correctly parsed.

[nayeemrmn]

Tsconfigs are detected in the directory, you shouldn't be using --config for them. It's likely being read as a deno.json, which doesn't support extends. It's showing up twice because it's also being read the intended way as mentioned, but being overrided by the other.

[EarlMilktea]

My bad! Thank you very much!

[EarlMilktea]

By the way, don't you think it's good to emit some messages when --config is used against tsconfig.json ...?