Commit c4797c0
fix: manual timer deadline resolution (#1273)
It seems sometimes Tokio's timer wheel may not advance (if the executor
is blocked) causing `Sleep` future to take more ticks to be woken up and
be `Poll::Ready` even after deadline passes. This fix adds an early
deadline check in `MutableSleep::poll_ready`.
```js
let ticked = false;
setTimeout(() => {
console.log("timer done");
ticked = true;
}, 1);
const now = Date.now();
while (Date.now() - now < 2);
setImmediate(() => {
console.log(ticked); // true
});
```
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>1 parent 6d7de19 commit c4797c0
1 file changed
+13
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
183 | 196 | | |
184 | 197 | | |
185 | 198 | | |
| |||
0 commit comments