Make this a non-breaking change

This will detect the current rubocop version and auto-enable
--editor-mode for newer version of rubocop without affecting users of
older versions of rubocop.

Author: maxjacobson

autoload/ale/fixers/rubocop.vim

@@ -1,7 +1,6 @@
 call ale#Set('ruby_rubocop_options', '')
 call ale#Set('ruby_rubocop_auto_correct_all', 0)
 call ale#Set('ruby_rubocop_executable', 'rubocop')
-call ale#Set('ruby_rubocop_editor_mode', '1')
 
 " Rubocop fixer outputs diagnostics first and then the fixed
 " output. These are delimited by a "=======" string that we
@@ -20,11 +19,11 @@ function! ale#fixers#rubocop#PostProcess(buffer, output) abort
     return a:output[l:line :]
 endfunction
 
-function! ale#fixers#rubocop#GetCommand(buffer) abort
+function! ale#fixers#rubocop#GetCommand(buffer, version) abort
     let l:executable = ale#Var(a:buffer, 'ruby_rubocop_executable')
     let l:options = ale#Var(a:buffer, 'ruby_rubocop_options')
     let l:auto_correct_all = ale#Var(a:buffer, 'ruby_rubocop_auto_correct_all')
-    let l:editor_mode= ale#Var(a:buffer, 'ruby_rubocop_editor_mode')
+    let l:editor_mode = ale#semver#GTE(a:version, [1, 61, 0])
 
     return ale#ruby#EscapeExecutable(l:executable, 'rubocop')
     \   . (!empty(l:options) ? ' ' . l:options : '')
@@ -33,9 +32,21 @@ function! ale#fixers#rubocop#GetCommand(buffer) abort
     \   . ' --force-exclusion --stdin %s'
 endfunction
 
-function! ale#fixers#rubocop#Fix(buffer) abort
+function! ale#fixers#rubocop#GetCommandForVersion(buffer, version) abort
     return {
-    \   'command': ale#fixers#rubocop#GetCommand(a:buffer),
-    \   'process_with': 'ale#fixers#rubocop#PostProcess'
+    \ 'command': ale#fixers#rubocop#GetCommand(a:buffer, a:version),
+    \ 'process_with': 'ale#fixers#rubocop#PostProcess'
     \}
 endfunction
+
+function! ale#fixers#rubocop#Fix(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'ruby_rubocop_executable')
+    let l:command = l:executable . ale#Pad('--version')
+
+    return ale#semver#RunWithVersionCheck(
+    \   a:buffer,
+    \   l:executable,
+    \   l:command,
+    \   function('ale#fixers#rubocop#GetCommandForVersion'),
+    \)
+endfunction

doc/ale-ruby.txt

@@ -187,18 +187,6 @@ g:ale_ruby_rubocop_auto_correct_all
   This variable can be changed to make rubocop to correct all offenses (unsafe).
 
 
-                                         *ale-options.ruby_rubocop_editor_mode*
-                                               *g:ale_ruby_rubocop_editor_mode*
-                                               *b:ale_ruby_rubocop_editor_mode*
-ruby_rubocop_editor_mode
-g:ale_ruby_rubocop_editor_mode
-  Type: |Number|
-  Default: `1`
-
-  This variable can be changed to 0 to run rubocop without the `--editor-mode`
-  flag (if using RuboCop < v1.61.0).
-
-
 ===============================================================================
 ruby                                                            *ale-ruby-ruby*
 

test/fixers/test_rubocop_fixer_callback.vader

@@ -1,53 +1,47 @@
 Before:
-  Save g:ale_ruby_rubocop_executable
-  Save g:ale_ruby_rubocop_options
-
-  " Use an invalid global executable, so we don't match it.
-  let g:ale_ruby_rubocop_executable = 'xxxinvalid'
-  let g:ale_ruby_rubocop_options = ''
-
-  call ale#test#SetDirectory('/testplugin/test/fixers')
+  call ale#assert#SetUpFixerTest('ruby', 'rubocop')
 
 After:
-  Restore
-
-  call ale#test#RestoreDirectory()
+  call ale#assert#TearDownFixerTest()
 
 Execute(The rubocop callback should return the correct default values):
   call ale#test#SetFilename('../test-files/ruby/dummy.rb')
 
-  AssertEqual
+  GivenCommandOutput ['1.61.0']
+
+  AssertFixer
   \ {
   \   'process_with': 'ale#fixers#rubocop#PostProcess',
   \   'command': ale#Escape(g:ale_ruby_rubocop_executable)
   \     . ' --auto-correct --editor-mode --force-exclusion --stdin %s',
-  \ },
-  \ ale#fixers#rubocop#Fix(bufnr(''))
+  \ }
 
 Execute(The rubocop callback should include custom rubocop options):
   let g:ale_ruby_rubocop_options = '--except Lint/Debugger'
   call ale#test#SetFilename('../test-files/ruby/with_config/dummy.rb')
 
-  AssertEqual
+  GivenCommandOutput ['1.61.0']
+
+  AssertFixer
   \ {
   \   'process_with': 'ale#fixers#rubocop#PostProcess',
   \   'command': ale#Escape(g:ale_ruby_rubocop_executable)
   \     . ' --except Lint/Debugger'
   \     . ' --auto-correct --editor-mode --force-exclusion --stdin %s',
-  \ },
-  \ ale#fixers#rubocop#Fix(bufnr(''))
+  \ }
 
 Execute(The rubocop callback should use auto-correct-all option when set):
   let g:ale_ruby_rubocop_auto_correct_all = 1
   call ale#test#SetFilename('../test-files/ruby/with_config/dummy.rb')
 
-  AssertEqual
+  GivenCommandOutput ['1.61.0']
+
+  AssertFixer
   \ {
   \   'process_with': 'ale#fixers#rubocop#PostProcess',
   \   'command': ale#Escape(g:ale_ruby_rubocop_executable)
   \     . ' --auto-correct-all --editor-mode --force-exclusion --stdin %s'
-  \ },
-  \ ale#fixers#rubocop#Fix(bufnr(''))
+  \ }
 
 Execute(The rubocop post-processor should remove diagnostics content):
   AssertEqual
@@ -88,14 +82,15 @@ Execute(The rubocop post-processor should remove diagnostics content):
   \   '         ''run'']',
   \ ])
 
-Execute(The rubocop callback should not use editor-mode option when configured not to):
-  let g:ale_ruby_rubocop_editor_mode = 0
+Execute(The rubocop callback should not use editor-mode option with older versions):
   call ale#test#SetFilename('../test-files/ruby/with_config/dummy.rb')
 
-  AssertEqual
+  GivenCommandOutput ['1.59.0']
+
+  AssertFixer
   \ {
   \   'process_with': 'ale#fixers#rubocop#PostProcess',
   \   'command': ale#Escape(g:ale_ruby_rubocop_executable)
-  \     . ' --auto-correct-all --force-exclusion --stdin %s'
-  \ },
-  \ ale#fixers#rubocop#Fix(bufnr(''))
+  \     . ' --auto-correct --force-exclusion --stdin %s'
+  \ }
+