refactor tools and move calculations for portfolio analysis to a dedicated calculations module

Author: denv3rr

README.md

@@ -284,7 +284,7 @@ Flight operator metadata can be extended by copying `config/flight_operators.exa
 
 ### AI Assistant (Draft)
 
-The assistant module is in progress. The API endpoint (`/api/assistant/query`) currently supports a limited rules-based summarizer; unsupported modes/questions return an explicit "not implemented" response. UI/CLI chat surfaces are planned. See `docs/ai_assistant.md` for the draft plan.
+The assistant module is in progress. The API endpoint (`/api/assistant/query`) currently supports a limited rules-based summarizer; unsupported modes/questions return a 501 response with an explicit "not implemented" payload and `meta` warnings. UI/CLI chat surfaces are planned. See `docs/ai_assistant.md` for the draft plan.
 
 ### AI Synthesis (Reports)
 

core/migration.py

@@ -1,10 +1,13 @@
 from __future__ import annotations
 
 import json
+import logging
+
+from pydantic import ValidationError
 
 from core.database import SessionLocal
 from core.db_management import create_db_and_tables
-from modules.client_mgr.payloads import normalize_clients_payload
+from modules.client_mgr.schema import Client
 from modules.client_store import DbClientStore
 
 
@@ -15,18 +18,29 @@ def migrate_data() -> None:
     db = SessionLocal()
     try:
         with open("data/clients.json", "r", encoding="utf-8") as f:
-            clients_data = json.load(f)
-        clients_data, _ = normalize_clients_payload(clients_data)
+            clients_raw_data = json.load(f)
+
+        if not isinstance(clients_raw_data, list):
+            logging.error("data/clients.json should contain a list of clients.")
+            return
+
+        clients_data = [Client.model_validate(c) for c in clients_raw_data]
+        logging.info(f"Found {len(clients_data)} clients in data/clients.json to migrate.")
+
         store = DbClientStore(db)
         store.sync_clients(
-            clients_data if isinstance(clients_data, list) else [],
+            [client.model_dump() for client in clients_data],
             delete_missing=False,
             overwrite=False,
         )
+        logging.info("Data migration completed successfully.")
+
+    except (json.JSONDecodeError, ValidationError) as e:
+        logging.error(f"Error migrating data from data/clients.json: {e}")
     finally:
         db.close()
 
-
 if __name__ == "__main__":
+    logging.basicConfig(level=logging.INFO)
     create_db_and_tables()
     migrate_data()

docs/ai_assistant.md

@@ -2,7 +2,7 @@
 
 ## Current Status
 - API route `/api/assistant/query` exists; limited rules-based summarizer handles client/news/tracker prompts.
-- Unsupported modes or questions return explicit "not implemented" responses.
+- Unsupported modes or questions return explicit "not implemented" payloads with a 501 status and `meta` warnings.
 - UI/CLI chat surfaces are not implemented yet.
 
 ## Goals
@@ -41,7 +41,7 @@
   - `warnings` (missing data, stale cache, or blocked sources)
 - No hallucinated numbers or placeholder examples.
 - If inputs are missing, return "Unavailable" with a reason.
-- Until the assistant is fully wired, unsupported queries return an explicit "not implemented" response with empty sources.
+- Until the assistant is fully wired, unsupported queries return a 501 response with empty sources and explicit warnings.
 
 ## Model Options
 - Default: rules-based summarizer and templated narratives over deterministic data.