Trilogy adapter support in Rails 8.1 by Austio · Pull Request #132 · departurerb/departure

Austio · 2025-09-18T21:50:23Z

This PR adds the ability for teams to use trilogy instead of mysql2 for their adapter. Basic logic is this

When we want trilogy and are rails 8.1
Load the trilogy adapter instead of the mysql2

Due to changes in #131 and #128 it is essentially a new adapter that does very little except pass alter statements to pt-online-schema-change and ensure that add/remove index have

There is some duplication in this that i will probably pull to a concern but opting to keep separate while in WIP

Logic for the adapter selection is documented in the readme

| Option                            | Default | What it Controls                                                                                                                                                          |
|-----------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| db_adapter_name                   | nil     | 'mysql2' or 'trilogy' - gives users an ability to provide the specific db adapter to override the db_adapter we use in departure see Db Adapter Support Below for details |

Db Adapter Support

Starting in Rails 8.1 we add support for the use of the trilogy database adapter gem. Logic for selecting an adapter follows this logic

Departure.configuration.db_adapter_name is set to 'mysql2' or 'trilogy' use that value
If the database configuration specifies 'mysql2 or 'trilogy' use that adapter
Default to mysql2

…ity statement

a host:port combo for connections to the db in tests

…_Mysql2Adapter

xjunior · 2025-09-23T13:59:21Z

README.md

+
+### Trilogy Adapter Support
+
+Starting in Rails 8.1 we add support for the use of the trilogy database adapter gem.  Logic for selecting an adapter follows this logic


Would it be a problem to support trilogy since rails 7.1?

I was also wondering if it wouldn't be possible to get that from the original connection. On my original attempt to implement trilogy support I remember trying that but ended up with the configuration like you did, but I was wondering whether that wasn't possible now.

You can derive it from the connection, i'm not 100% there yet with this pr but once i am we can answer the pre 8.1 for complexity if someone is actually needing in rails 8.0 or before.

My initial thought is to put it in 8.1 and beyond so that as people upgrade they will be able to use it.

7.1 is EOL October 1st

7.1 -> 8.0 and 8.0 -> 8.1 are easy upgrades, so I won't bother about supporting previous versions.

xjunior · 2025-09-23T13:59:46Z

lib/active_record/connection_adapters/rails_8_1_mysql2_adapter.rb

@@ -33,8 +33,6 @@ def visit_DropForeignKey(name) # rubocop:disable Naming/MethodName
        end
      end

-      extend Forwardable


Did we forget this here in previous PRs?

🙈 yes my bad

xjunior · 2025-09-23T14:02:23Z

lib/departure.rb

 # We need the OS not to buffer the IO to see pt-osc's output while migrating
 $stdout.sync = true

-Departure::RailsAdapter.for_current.register_integrations


Why is this not needed anymore? Did this get moved to the railtie?

Still tinkering but hoping to pull all the registration into the railtie, if not this will have to work and go back in

+1 on this, a railtie is the most appropriate place for registration.

…on now that we aren't automatically connecting to departure when loading the library and instead putting that logic in a railtie

… and yeild a block

…abase helper in integration spec

…7 tests

Failure/Error: test_database.setup ActiveRecord::ConnectionNotEstablished: trilogy_auth_recv: caching_sha2_password requires either TCP with TLS or a unix socket: TRILOGY_UNSUPPORTED

Austio · 2025-12-10T00:14:24Z

lib/active_record/connection_adapters/rails_8_1_trilogy_adapter.rb

+require 'departure'
+require 'forwardable'
+
+module ActiveRecord


Core change - add rails 8.1 trilogy adapter

Austio · 2025-12-10T00:14:47Z

lib/departure/rails_adapter.rb

+        # rubocop:enable Metrics/PerceivedComplexity
        if ar_version::MAJOR == 8 && ar_version::MINOR.positive?
-          V8_1_Adapter
+          if db_connection_adapter == 'trilogy'


Core change - allow trilogy to be a specified adapter

…nside of our initializer

…ILS_8_1

Austio added 4 commits September 18, 2025 14:43

Add trilogy adapter to rails-8-1 gemfile

235b0d3

Setup trilogy test in yml

3a4eb44

Add configuration to switch Departure database adapter version

580bc8f

Rename Rails81DepartureAdapter to Rails81Mysql2Adapter

0a35ff9

Austio force-pushed the trilogy-adapter-support branch from 03dd91d to 0a35ff9 Compare September 18, 2025 21:50

Austio added 2 commits September 18, 2025 16:06

Add trilogy database adapter

b276a0e

Add spec for mysql/trilogy alter statement commands in adapter

90426d5

Austio force-pushed the trilogy-adapter-support branch 3 times, most recently from 96f4d58 to 3ae2df4 Compare September 19, 2025 15:47

Move require statement for trilogy after the active record compatibil…

a525937

…ity statement

Austio force-pushed the trilogy-adapter-support branch from 3ae2df4 to a525937 Compare September 19, 2025 16:15

Add spec for returning trilogy adapter when it is specified

fcabff4

Austio force-pushed the trilogy-adapter-support branch 2 times, most recently from 828f1ab to 56cb327 Compare September 19, 2025 21:27

Move departure adapter loading to after_initialize hooks

6b38704

Austio force-pushed the trilogy-adapter-support branch 3 times, most recently from e71729b to d9131a8 Compare September 22, 2025 19:38

Remove adapter column from rails 8.1. Update configy.yml.erb to expose

7b1112f

a host:port combo for connections to the db in tests

Austio force-pushed the trilogy-adapter-support branch from d9131a8 to 7b1112f Compare September 22, 2025 19:38

Austio added 4 commits September 22, 2025 12:50

Add spec asserting that we are indeed connecting to the correct adapter

e0989bd

Rename constants in spec files from V8_1_Adapter to the specific V8_1…

e38df06

…_Mysql2Adapter

Attempt to adjust CI file to allow trilogy connection

efbb11f

Define column in rails 8.0 and rails 8.1

1947f30

xjunior reviewed Sep 23, 2025

View reviewed changes

Austio added 2 commits September 23, 2025 08:40

Move setup_departure_integration helper and use in Departure::Migrati…

2aaef93

…on now that we aren't automatically connecting to departure when loading the library and instead putting that logic in a railtie

Refactor database to have different configs build a consistent config…

fa01812

… and yeild a block

Austio added 9 commits November 5, 2025 13:55

Update database.yml to use either socket or host exclusively. Use dat…

d9f47fa

…abase helper in integration spec

Bump rails appraisal file to 8.1.1

801e492

Run rubocop

1e6470e

Add spec for rails 8.0 adapter

3cbb35c

Update appraisal spec to be rails 8.1 instead of rails 8.1.0.beta1

edce126

Add test helper to skip loading rails 8.0 and 8.1 when running rails …

2ab05a5

…7 tests

Update test.yml to not run sudoe to alter user permissions for mysql

b315873

Merge branch 'master' into trilogy-adapter-support

4e5b9b9

Readd rails errors for 7.1 and 6.1 being unsupported

5602188

Austio force-pushed the trilogy-adapter-support branch 4 times, most recently from ec5f4dd to 81cbeaa Compare December 9, 2025 23:46

Run rubocop

aad936b

Austio force-pushed the trilogy-adapter-support branch from 81cbeaa to aad936b Compare December 9, 2025 23:49

Add mysql flush for priviledges due to trilogy error

41a1fd5

Failure/Error: test_database.setup ActiveRecord::ConnectionNotEstablished: trilogy_auth_recv: caching_sha2_password requires either TCP with TLS or a unix socket: TRILOGY_UNSUPPORTED

Austio commented Dec 10, 2025

View reviewed changes

Add register_integrations class method to rails adapater. Call that i…

d2a2880

…nside of our initializer

Austio force-pushed the trilogy-adapter-support branch from abe54c7 to d2a2880 Compare December 10, 2025 18:52

Austio marked this pull request as ready for review December 10, 2025 19:25

Disable line too long rubocop in specs. This is not helpful

9fbc420

Austio changed the title ~~(wip) Trilogy adapter support~~ Trilogy adapter support in Rails 8.1 Dec 10, 2025

Austio force-pushed the trilogy-adapter-support branch 2 times, most recently from 0ae5621 to 9fbc420 Compare December 10, 2025 19:37

Update rails version under test in rails8.1 for mysql to reference RA…

db7679d

…ILS_8_1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trilogy adapter support in Rails 8.1#132

Trilogy adapter support in Rails 8.1#132
Austio wants to merge 30 commits intomasterfrom
trilogy-adapter-support

Austio commented Sep 18, 2025 •

edited

Loading

Uh oh!

xjunior Sep 23, 2025

Uh oh!

xjunior Sep 23, 2025

Uh oh!

Austio Sep 23, 2025

Uh oh!

guilleiguaran Oct 14, 2025

Uh oh!

xjunior Sep 23, 2025

Uh oh!

Austio Sep 23, 2025

Uh oh!

xjunior Sep 23, 2025

Uh oh!

Austio Sep 23, 2025

Uh oh!

guilleiguaran Oct 14, 2025

Uh oh!

Austio Dec 10, 2025

Uh oh!

Austio Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		### Trilogy Adapter Support

		Starting in Rails 8.1 we add support for the use of the trilogy database adapter gem. Logic for selecting an adapter follows this logic

Conversation

Austio commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Db Adapter Support

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Austio commented Sep 18, 2025 •

edited

Loading