Refactor API client to reduce duplication

Author: yeikel

updater/lib/dependabot/api_client.rb

@@ -76,15 +76,7 @@ def update_pull_request(dependency_change, base_commit_sha)
             "base-commit-sha": base_commit_sha
           }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -96,15 +88,7 @@ def close_pull_request(dependency_names, reason)
 
         api_url = "#{base_url}/update_jobs/#{job_id}/close_pull_request"
         body = { data: { "dependency-names": dependency_names, reason: reason } }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -123,15 +107,7 @@ def record_update_job_error(error_type:, error_details:)
             "error-details": error_details
           }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -158,15 +134,7 @@ def record_update_job_warning(warn_type:, warn_title:, warn_description:)
             "warn-description": warn_description
           }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -184,15 +152,7 @@ def record_update_job_unknown_error(error_type:, error_details:)
             "error-details": error_details
           }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -204,15 +164,7 @@ def mark_job_as_processed(base_commit_sha)
 
         api_url = "#{base_url}/update_jobs/#{job_id}/mark_as_processed"
         body = { data: { "base-commit-sha": base_commit_sha } }
-        response = http_client.patch(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -228,15 +180,7 @@ def update_dependency_list(dependencies, dependency_files)
             dependency_files: dependency_files
           }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -249,17 +193,9 @@ def create_dependency_submission(dependency_submission)
         body = {
           data: dependency_submission
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
+        end
       end
-    end
 
     sig { params(ecosystem_versions: T::Hash[Symbol, T.untyped]).void }
     def record_ecosystem_versions(ecosystem_versions)
@@ -268,15 +204,7 @@ def record_ecosystem_versions(ecosystem_versions)
         body = {
           data: { ecosystem_versions: ecosystem_versions }
         }
-        response = http_client.post(api_url, json: body)
-        raise ApiError, response.body if response.code >= 400
-      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError
-        retry_count ||= 0
-        retry_count += 1
-        raise if retry_count > MAX_REQUEST_RETRIES
-
-        sleep(rand(3.0..10.0))
-        retry
+        send_post_request_with_network_retries(api_url, body)
       end
     end
 
@@ -406,6 +334,30 @@ def record_cooldown_meta(job)
 
     private
 
+    sig { params(url: String, body: T::Hash[T.untyped, T.untyped]).returns(Excon::Response) }
+    # Sends a POST request to the given API URL with the provided body.
+    # Retries the request up to MAX_REQUEST_RETRIES times in case of network errors.
+    # Raises ApiError if the response code is >= 400.
+    #
+    # @param api_url [String] The endpoint to send the POST request to.
+    # @param json [Hash] The JSON body to send in the request.
+    # @return [Excon::Response] The response from the API.
+    def send_post_request_with_network_retries(api_url, json)
+      retry_count ||= 0
+
+      begin
+        response = http_client.post(api_url, json)
+        raise ApiError, response.body if response.code >= 400
+        response
+      rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError => e
+        retry_count += 1
+        raise e if retry_count > MAX_REQUEST_RETRIES
+
+        sleep(rand(3.0..10.0))
+        retry
+      end
+    end
+
     # Update return type to allow returning a Hash or nil
     sig do
       params(version_manager: T.nilable(Dependabot::Ecosystem::VersionManager))